Do not use libgmp automatically in libsecp256k1 #5531

1. 
   sipa commented at 1:23 PM on December 23, 2014: member

   Hotfix the libsecp256k1 subtree to not automatically use gmp when it is available, to avoid an unwanted dependency.

2. Do not use libgmp automatically in libsecp256k1 63b5a1dc80
3. laanwj added this to the milestone 0.10.0 on Dec 23, 2014
4. 
   Diapolo commented at 1:40 PM on December 23, 2014: none

   Just asking, what happens when not using it during build of libsecp256k1? Are you using own routines for doing what libgmp was used for?

5. 
   sipa commented at 1:45 PM on December 23, 2014: member

   @Diapolo indeed. GMP can be used for getting a faster modular inverse implementation, or for implementing field arithmetic (operations modulo p = 2^256 - 2^32 - 977), while there are other implementations for both too.

6. 
   laanwj commented at 2:14 PM on December 23, 2014: member

   Tested ACK

7. 
   laanwj commented at 2:15 PM on December 23, 2014: member

   @diapolo yes, and note that libgmp is not used for any routines that version 0.10 actually uses from secp256k1 (ie, signing), so it was a useless dependency

8. laanwj merged this on Dec 23, 2014
9. laanwj closed this on Dec 23, 2014

   ---

10. laanwj referenced this in commit f4dcc1e009 on Dec 23, 2014
11. 
    theuni commented at 7:12 PM on December 23, 2014: member

    after-the-fact ACK.

12. 
    morcos commented at 8:45 PM on January 15, 2015: member

    @laanwj Just wanted to verify that this wasn't supposed to be merged into master also?

13. 
    laanwj commented at 8:31 AM on January 16, 2015: member

    This should end up in master through a normal secp256k1 update, see @sipa's other pulls. E.g. #5506 may have it.

14. 
    rubensayshi commented at 11:10 AM on February 5, 2015: contributor

    @laanwj @sipa #5506 does not have it, just FYI

15. MarcoFalke locked this on Sep 8, 2021

Milestone
0.10.0