rename checkwork #5549

pull ghost wants to merge 10 commits into bitcoin:master from changing 4 files +41 −4

ghost commented at 5:40 PM on December 27, 2014: none

not sure if this isupposed to be going one way or the other, so i renamed it to match

build: fix 'make distcheck'

Rather than treating the .py as a regular built test, run it from check-local
so that we can better control the paths used.

be43492945

Adding RPC tests for the following wallet related calls: getbalance,

listsinceblock, listtransactions, listlockunspent, listaccounts
listaddressgroupings

7c5dd60306

rename checkwork 60b21d203f
Fix typo 244fdc7bee
Diapolo commented at 11:02 AM on December 28, 2014: none

Is that function used anywhere? The build should break if you just rename it??
paveljanik commented at 9:10 PM on December 28, 2014: contributor

The declaration of CheckWork is in miner.h only. It is not defined at all. See #4603 for more details. The new function ProcessBlockFound is used in miner.cpp only, and only after its definition, we do not need it there at all... I'd just delete the line.
Merge pull request #5558
99913f0 Fix reference. (Thomas Zander)
f8c48589cf
Merge pull request #5554
244fdc7 Fix typo (Julian Yap)
5f5f14e9f2

Merge pull request #5530

7c5dd60 Adding RPC tests for the following wallet related calls: getbalance, listsinceblock, listtransactions, listlockunspent, listaccounts listaddressgroupings (Everett Forth)

565b3008ec

Merge pull request #5514

be43492 build: fix 'make distcheck' (Cory Fields)

ed11d53077

jonasschnelli commented at 9:17 AM on December 29, 2014: contributor

ACK

The current defined function in miner.h (bool CheckWork(CBlock* pblock, CWallet& wallet, CReserveKey& reservekey);) as no implementation because it was renamed in #4603 (but header was not updated). This PR makes totally sense.
jonasschnelli commented at 9:59 AM on December 29, 2014: contributor

@bitcreditscc Even better would be to completely remove the CheckWork() definition in the header. There is no use outside of miner.cpp.
ghost commented at 10:55 AM on December 29, 2014: none

ok i'll do that however on my own tree i still keep getwork
unknown closed this on Dec 29, 2014
unknown reopened this on Dec 29, 2014
rename checkwork 9ef473e105
Merge branch 'master' of https://github.com/bitcreditscc/bitcoin 065d4b2012
laanwj referenced this in commit 269d8ba0d2 on Jan 2, 2015
laanwj commented at 4:32 PM on January 2, 2015: member

Good catch, but I went for removal + make static instead, see 269d8ba
laanwj closed this on Jan 2, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors