Subtle bug in #1647 (was: 0.10: Potentially-consensus-affecting bug in BIP30 implementation) #5579

issue luke-jr opened this issue on December 30, 2014

luke-jr commented at 11:18 PM on December 30, 2014: member

For some reason (that appears unrelated to the pull request itself), #1647 (specifically 448cadbf7c763af5fc8ff5be77e6eb855ed83067) breaks miner_tests (line 109). CreateNewBlock's template is rejected by ConnectBlock because of the BIP30 duplicate-txid check, failing on the last transaction, which AccessCoins returns a height of 111 for (despite chainActive.Tip()->nHeight being only 110). I have been unable to determine thus far what the root of this problem is, but it may have the potential to affect consensus since if it rejects a valid block.
luke-jr commented at 3:04 AM on December 31, 2014: member

Turned out to be a subtle bug in #1647.
luke-jr closed this on Dec 31, 2014
luke-jr commented at 3:35 AM on December 31, 2014: member

#5580 can prevent issues like this in the future (the code would refuse to compile).
luke-jr renamed this:
~~0.10: Potentially-consensus-affecting bug in BIP30 implementation~~
Subtle bug in #1647 (was: 0.10: Potentially-consensus-affecting bug in BIP30 implementation)
on Dec 31, 2014
MarcoFalke locked this on Sep 8, 2021

Contributors