-c will vary the loop counter -i will vary the iterations per-loop -w will change the WINDOW_G table size setting at runtime (primary reason for patch)
secp256k1 benchmarking programs can now accept parameters #5607
pull midnightmagic wants to merge 1 commits into bitcoin:master from midnightmagic:secp_bench_getopt changing 9 files +163 −31-
midnightmagic commented at 3:10 PM on January 6, 2015: contributor
-
1f2c267135
secp256k1 benchmarking programs now accept parameters
-c will vary the loop counter -i will vary the iterations per-loop -w will change the WINDOW_G table size setting at runtime (primary reason for patch)
-
sipa commented at 3:17 PM on January 6, 2015: member
Useful functionality, but:
- Please submit to the https://github.com/bitcoin/secp256k1 repository.
- None of the internal libsecp256k1 code is C++, so no need for #ifdef cplusplus markers.
- A cleaner way for abstraction is passing the window G size to the secp256k1_start() method.
- Please don't duplicate command-line parsing code 4 times (it could go in bench.h, though).
-
midnightmagic commented at 4:07 PM on January 6, 2015: contributor
- Okay
- Okay
- I'd presumed you'd wanted the lib perturbed as absolutely little as possible for confidence reasons; additionally, changing the _start() to take an argument rather than using a mutator or visible global would require either a varargs or an incompatible interface change. So.. I'll presume you're okay with an interface change after all. Originally I'd modified all library calls to pass the tablesize through function arguments but the mod was very extensive and invasive.
- Okay
- midnightmagic closed this on Jan 6, 2015
- MarcoFalke locked this on Sep 8, 2021
Contributors