minor changes in db/walletdb (e.g. constify some std::string references) #5616

1. 
   Diapolo commented at 8:50 am on January 8, 2015: none
2. move ThreadFlushWalletDB declaration do walletdb.h

   - the definition is already in walletdb.cpp

   d9727fb471
3. constify some std::string references in db/walletdb 40007262f7
4. remove 2 unused classes from db.h 4fbfbf9b07
5. 
   laanwj commented at 9:09 am on January 8, 2015: member

   ACK on d9727fb 4000726 4fbfbf9 NACK on 0134b6b, the change in CDBEnv::CloseDb is unnecessary, and the rest of the changes are just some idle whitespace changes and move-declarations-around.
6. laanwj added the label Improvement on Jan 8, 2015
7. 
   Diapolo commented at 9:36 am on January 8, 2015: none

   @laanwj Removed number 4.
8. 
   laanwj commented at 5:21 pm on January 20, 2015: member

   Now that the newwallet work is starting (#5686). I want to discourage any changes to the old wallet code not strictly necessary. So I’m closing this, sorry.
9. laanwj closed this on Jan 20, 2015

   ---

10. 
    Diapolo commented at 7:38 pm on January 20, 2015: none

    Yeah nothing new…
11. Diapolo deleted the branch on Jan 20, 2015
12. MarcoFalke locked this on Sep 8, 2021

Contributors
Diapolo laanwj

Labels
Refactoring