minor changes in db/walletdb (e.g. constify some std::string references) #5616

pull Diapolo wants to merge 3 commits into bitcoin:master from Diapolo:db changing 4 files +9 −14

Diapolo commented at 8:50 AM on January 8, 2015: none

No description provided.
move ThreadFlushWalletDB declaration do walletdb.h
- the definition is already in walletdb.cpp
d9727fb471
constify some std::string references in db/walletdb 40007262f7
remove 2 unused classes from db.h 4fbfbf9b07
laanwj commented at 9:09 AM on January 8, 2015: member

ACK on d9727fb 4000726 4fbfbf9 NACK on 0134b6b, the change in CDBEnv::CloseDb is unnecessary, and the rest of the changes are just some idle whitespace changes and move-declarations-around.
laanwj added the label Improvement on Jan 8, 2015
Diapolo commented at 9:36 AM on January 8, 2015: none

@laanwj Removed number 4.
laanwj commented at 5:21 PM on January 20, 2015: member

Now that the newwallet work is starting (#5686). I want to discourage any changes to the old wallet code not strictly necessary. So I'm closing this, sorry.
laanwj closed this on Jan 20, 2015
Diapolo commented at 7:38 PM on January 20, 2015: none

Yeah nothing new...
Diapolo deleted the branch on Jan 20, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels