[QT] Win: icon coloring issue tray-menu #5625

jonasschnelli commented at 10:30 AM on January 9, 2015: contributor

@luke-jr would you mind have a look at it?

bildschirmfoto 2015-01-09 um 11 13 47

Light blue color for std. theme is okay. I still would prefer the black one... but i'm fine with the auto-color.

bildschirmfoto 2015-01-09 um 11 03 46

classic theme also looks okay: bildschirmfoto 2015-01-09 um 11 16 27

laanwj added the label GUI on Jan 9, 2015

laanwj commented at 10:33 AM on January 9, 2015: member

The dark blue looks nice, the light blue just doesn't have enough contrast with the white (esp. visible in the small icons in the status line). I think light colors should only be used on dark backgrounds.

jonasschnelli commented at 10:37 AM on January 9, 2015: contributor

@laanwj Agree with that. I'm also questioning myself if it makes sense to use the color-manipulating on windows. I would prefer black icons on windows. Linux makes sense. OSX will always be black.

Diapolo commented at 1:05 PM on January 9, 2015: none

I also said that a few days ago, it looks a little strange IMHO.

jonasschnelli commented at 1:17 PM on January 9, 2015: contributor

@Diapolo I open this issue to move the discussion from the close PR (https://github.com/bitcoin/bitcoin/pull/5493)

jonasschnelli commented at 7:53 AM on January 13, 2015: contributor

Related to #5653

zander commented at 10:31 AM on January 13, 2015: none

As mentioned elsewhere;

In any example I try to find having monochrome icons that follow the text color just isn't what happens, and the result just looks broken. Its completely inconsistent with all the other apps because they all use color icons. Its also inconsistent with itself because the "Show / Hide" for instance is not actually the logo you see in the taskbar, its got a different color.

Bottom line, I have zero applications on either Windows (8.1) nor on Linux (KDE and Gnome) that have monochrome icons in their systray context menu. So this just doesn't look consistent in any way at all.

Sorry if this is not the place to have this discussion; without a mailinglist its really really hard to find "decisions" that just don't get seen by me and any other stakeholders. So please tell me where you actually talk about these things.

laanwj commented at 11:13 AM on January 13, 2015: member

Ubuntu has monochrome (even: grey) icons in their systray as well as systray menus.

zander commented at 11:22 AM on January 13, 2015: none

Sure, the icons are monochrome. But the popup menu icons are not.

laanwj commented at 11:39 AM on January 13, 2015: member

Here they are, at least the 'official' ones, this shows e.g. the language selection menu: naamloos It's the same for the network menu, and battery. Everything is grey. Just as I like it. Xpra is the odd duck out by having a colored icon and colored icons in the menu.

In any case, to go back to the issue: I don't think it's really disturbing but yes, having send and receive in a different color as the others is inconsistent.

luke-jr referenced this in commit 6ddd105e61 on Jan 13, 2015

laanwj closed this on Jan 14, 2015

MarcoFalke locked this on Sep 8, 2021