From JoelKatz's 4diff. Is this safe?
Remove 2 second sleep from CheckWork #564
pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:optimize_remove_CheckWork_delay changing 1 files +0 −1-
luke-jr commented at 8:54 PM on October 4, 2011: member
-
Remove 2 second sleep from CheckWork 514b18722a
-
gavinandresen commented at 2:19 PM on October 5, 2011: contributor
How would this be tested ?
-
luke-jr commented at 3:04 PM on October 5, 2011: member
I suppose we could hack bitcoind to freeze every other thread at the start of CheckWork, and replace this sleep with a temporary thread that simply unfreezes the other threads after 10 seconds. That would have the effect of making this a Sleep(-10), and giving a window of time to try to get it to misbehave...
-
mikeallisonJS commented at 1:59 AM on October 6, 2011: none
I've had no trouble running w/o the 2second sleep. In fact I remove it from all my clients.
- gavinandresen referenced this in commit 32ebde4612 on Oct 6, 2011
- gavinandresen merged this on Oct 6, 2011
- gavinandresen closed this on Oct 6, 2011
- coblee referenced this in commit 17c0d22ff2 on Jul 17, 2012
- ptschip referenced this in commit a7c2efdbe3 on May 30, 2017
- lateminer referenced this in commit b7050195db on May 5, 2021
- DrahtBot locked this on Sep 8, 2021
Contributors