Move RPC-related sources to src/rpc/ #5705

pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:rpc_dir changing 22 files +44 −44
  1. luke-jr commented at 11:42 AM on January 25, 2015: member

    No description provided.

  2. Move RPC-related sources to src/rpc/ e775ef0d82
  3. laanwj added the label RPC on Jan 25, 2015
  4. laanwj commented at 12:42 PM on January 25, 2015: member

    I like the idea to move the RPC files, but before we go moving files around I'd like to make sure this is the eventual solution (to not make the mistake of 0.10 to play musical chairs with the file paths :-) ). And also to make sure this doesn't collide with existing efforts.

    RPC as we regard it actually consists of multiple components:

    • A. RPC server library (rpcserver.cpp) - general, seperated out in #5107
    • B. RPC handlers for bitcoind (rpcblockchain.cpp, rpcwallet.cpp, ...)
    • C. HTTP server (part of rpcserver.cpp and rpcprotocol.cpp now) - general, separated out in #5677
    • D. RPC protocol support (part of rpcprotocol.cpp)
    • E. RPC client library (rpcclient.cpp) - only one function that converts linear CLI arguments to requests structure. Used by GUI and bitcoin-cli
    • F. HTTP+RPC command-line client (bitcoin-cli.cpp)

    There is also:

    • G. JSON parsing and serialization - now using spirit, replaced with internal implementation in #4738

    Is it too crude to move A-E all to the same directory? To think of a logical separation, one'd want to separate client, server and common. e.g.

    • rpc-server: A,B,C
    • rpc-client: E (and possibly F, but having utiltiies top-level source in src/ makes sense)
    • rpc-common: D,G

    (or rpc/server, rpc/client, rpc/common respectively, but I personally don't like having source files in deep directory hierarchies)

  5. laanwj commented at 4:09 PM on March 16, 2015: member

    Closing this for now, can be revived after other RPC changes as mentioned above are in.

  6. laanwj closed this on Mar 16, 2015

  7. MarcoFalke locked this on Sep 8, 2021
Contributors

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me