Push down RPC locks #5711

1. 
   laanwj commented at 12:56 pm on January 26, 2015: member

   Rebased version of #5107.

   • update for RPC methods added since 84d13ee: setmocktime, invalidateblock, reconsiderblock. Only the first, setmocktime, required a change, the other two are thread safe.
   • remove no-longer-used threadSafe column from RPC table
   • remove duplicate invalidateblock and reconsiderblock from RPC table
2. laanwj added the label RPC on Jan 26, 2015
3. Removed main.h dependency from rpcserver.cpp

   Rebased by @laanwj:
   
   - update for RPC methods added since 84d13ee: setmocktime,
     invalidateblock, reconsiderblock. Only the first, setmocktime, required a change,
     the other two are thread safe.

   4401b2d7c5
4. Trim RPC command table

   - invalidateblock and reconsiderblock were defined doubly
   - remove no-longer-used threadSafe, as locks have been pushed down

   5ebe0956b3
5. laanwj force-pushed on Jan 28, 2015
6. 
   jonasschnelli commented at 8:00 am on February 2, 2015: contributor

   Tested ACK.
7. 
   jonasschnelli commented at 8:03 am on February 2, 2015: contributor

   I assume there is a minimal post PR overhaul of https://github.com/bitcoin/bitcoin/blob/master/src/rpcmining.cpp#L444 required. IMO not urgent.
8. laanwj merged this on Feb 4, 2015
9. laanwj closed this on Feb 4, 2015

   ---

10. laanwj referenced this in commit 87ecfb0f96 on Feb 4, 2015
11. 
    sdaftuar commented at 3:15 pm on February 4, 2015: member

    This commit appears to have broken the rpc-test getblocktemplate_longpoll.py. Relevant failure:

    0  File "./getblocktemplate_longpoll.py", line 66, in run_test
    1    assert(thr.is_alive())
    

    I’m not familiar enough with the test yet to understand what is going on, but I verified the test broke at this commit and succeeds in the previous one.

12. 
    jonasschnelli commented at 3:26 pm on February 4, 2015: contributor

    I can confirm that the test is broken. Assertion failed: (!pthread_mutex_unlock(&m)), function unlock...

    I think it has to do with the LEAVE_CRITICAL_SECTION.

13. jonasschnelli referenced this in commit 17115d0a34 on Feb 4, 2015
14. 
    jonasschnelli commented at 3:36 pm on February 4, 2015: contributor

    I don’t see a need for https://github.com/bitcoin/bitcoin/blob/master/src/rpcmining.cpp#L451 LEAVE and ENTER crictial section. But maybe i’m wrong.
15. lucayepa referenced this in commit 36f24f1a78 on Mar 9, 2015
16. random-zebra referenced this in commit 7a849ca06a on Jul 1, 2020
17. MarcoFalke locked this on Sep 8, 2021

Contributors
laanwj jonasschnelli sdaftuar

Labels
RPC/REST/ZMQ