1. 
   wtogami commented at 6:37 AM on January 27, 2015: contributor

   Coin Control: Fix fee labels when switching between Smart and Custom Fees

   The logic was just backwards.

   Before:

   After:

   Coin Control: Fix fee labels when nBytes >= 1000

   It appears that nBytes < 1000 was intended to compare to MAX_FREE_TRANSACTION_CREATE_SIZE for the purpose of excluding free transactions. It turns out however that the byte size of the transaction is irrelevant to the desired purpose of this conditional.

   Before:

   After:

   Tested:

   • Before this patch the Smart Fee label prefix happens when you cross the nBytes > 1000 boundary.
   • If you check the "Send as zero-fee if possible" box it behaves as expected.
2. Coin Control: Fix fee labels when switching between Smart and Custom Fees 349b55ae11
3. Coin Control: Fix fee labels when nBytes >= 1000

   It appears that nBytes < 1000 was intended to compare to MAX_FREE_TRANSACTION_CREATE_SIZE
   for the purpose of excluding free transactions.  It turns out however that the byte size
   of the transaction is irrelevant to the desired purpose of this conditional.

   468e050365
4. wtogami renamed this:
   Coin Control: Fix fee labels when switching between Smart and Custom Fees
   Coin Control: Fix fee labels with Custom Fees
   on Jan 27, 2015
5. laanwj added the label GUI on Jan 27, 2015
6. laanwj added this to the milestone 0.10.0 on Jan 27, 2015
7. 
   cozz commented at 5:14 PM on January 27, 2015: contributor

   I cant follow you. This pr rather introduces the bugs.

   The first use case shows a 226 byte transaction with "pay only the minimum fee" selected.

   • "Before" is 226 satoshis, which is correct, its the minimum fee
   • "After" shows 1000 satoshis, which is wrong, its not the minimum fee and its not "per kilobyte" (as shown in the radio button) but rather this is "total at least". But the minimum fee is not "total at least". The minimum fee is "per kilobyte".

   The second use case shows a 1114 bytes transaction. The difference is only the "~" sign in front of the fee.

   • "Before" has the "~" which is correct
   • "After" doesnt which is wrong

   Coin control guesses the transaction size and with that, it also guesses the fee. So we need a "~" in front of the fee. However, there is one use case, where we dont show the "~". This is if you select "total at least" and the transaction is < 1000 bytes. Because in that case you just pay what you entered. But if the transaction is > 1000 bytes, both radio buttons pay per kilobyte. Read the tooltip of "total at least". So if > 1000 bytes we always need a "~", but your screenshot doesnt show a "~".

   What I worry about, is that if even we developers got confused by this, then its probably not clear enough. I thought the tooltips would be enough explanation for a sophisticated users. Suggestions welcome.

8. 
   jonasschnelli commented at 7:20 PM on January 27, 2015: contributor

   Thanks @cozz for your response.

   IMO the behavior and labeling is okay and expert users should be capable to understand this. It's also behind a "expert" opt in setting so it should be clear to everyone that it may need some seconds to fully understand CoinControl.

   Personally I would get confused because of the recent added double-tilde in front of the aprox. values. But I also understand the concerns of difficult distinction between tilde and dash.

   PR: NACK

9. 
   wtogami commented at 8:45 PM on January 27, 2015: contributor

   OK, I was surprised by the rounding behavior. There is a different bug here, let me think how to best demonstrate it.

10. 
    wtogami commented at 5:17 AM on January 28, 2015: contributor

    OK, it seems I fully misunderstood the rounding behavior change. This makes sense now.

11. wtogami closed this on Jan 28, 2015

    ---

12. wtogami deleted the branch on Jan 28, 2015
13. DrahtBot locked this on Sep 8, 2021

Contributors

wtogamicozzjonasschnelli

Milestone
0.10.0