Payment protocol: Can change amount displayed using scroll wheel #5724

issue luke-jr opened this issue on January 30, 2015
  1. luke-jr commented at 12:27 PM on January 30, 2015: member

    I can't type in numbers, but the scroll wheel will change the amount displayed just fine. Sending seems to ignore the changed value, though, so this is mostly cosmetic (although users might get annoyed if they try to send 0.01 BTC and end up sending the original 0.10 BTC amount...)

  2. jonasschnelli commented at 12:54 PM on January 30, 2015: contributor

    I tried this with last nights nighty build and cannot reproduce this issue. I tried with the mouse-scroll wheel as well by pressing the up/down button. I could not change the value in the field.

    Tested on OSX, Windows 7 and Ubuntu.

    bildschirmfoto 2015-01-30 um 13 46 41 bildschirmfoto 2015-01-30 um 13 51 20

    bildschirmfoto 2015-01-30 um 13 54 27

  3. luke-jr commented at 1:06 PM on January 30, 2015: member

    It affects at least c5044bc1693ced50ed070a27e7d2f3174202ace5 for me.

  4. jonasschnelli commented at 1:09 PM on January 30, 2015: contributor

    I did a test with 9fe53a85e0e50ca82e369b7d29485a0a6f0f8dbf. Maybe you find time to retest with current master or https://builds.jonasschnelli.ch/nightlybuilds/2015-01-30/.

  5. luke-jr commented at 1:29 PM on January 30, 2015: member

    Confirmed this is fixed in d781d4725cf49dff8408e61e09dbc8b8db621e75, so maybe just needs a 0.10 backport.

  6. jonasschnelli commented at 1:33 PM on January 30, 2015: contributor

    If it's not a 0.10 blocker it might be better to take this into the next release? Nevertheless we first need to find the fixing commit.

  7. luke-jr commented at 1:40 PM on January 30, 2015: member

    Confirmed this was fixed by 0fd9e2bf43d217d9a76003476661c8ab53606548 [Qt] don't allow amount changes when AmountSpinBox is read-only

  8. laanwj commented at 2:19 PM on January 30, 2015: member

    Backported that commit to 0.10 as 6a02ef8

  9. laanwj closed this on Jan 30, 2015

  10. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me