Dumpprivkey #574

pull sipa wants to merge 5 commits into bitcoin:master from sipa:dumpprivkey changing 16 files +422 −155

sipa commented at 2:54 PM on October 7, 2011: member
Introduces three new RPC calls:
- dumpprivkey: retrieve the private key corresponding to an address
- importprivkey: add a private key to your wallet
- removeprivkey: delete a private key from your wallet
sipa commented at 3:15 PM on October 7, 2011: member

This is a limited version of #220 that does not include the wallet import/export code; only key import/export/remove.
jgarzik commented at 8:19 PM on October 8, 2011: contributor

ACK
gavinandresen commented at 1:57 PM on October 11, 2011: contributor

NACK for version 0.5 -- I think removeprivkey needs at least a warning that it can modify unrelated account balances, and maybe a dump of what it did to the wallet so there is some chance of an 'undo' if the wrong key is removed.
Make CWalletTx::pwallet private 4c6e22953e
Add GetSecret() and GetKeys() to CKeyStore 93db3fceac
CBitcoinSecret added (base58 encoded privkey) 15a8590ecf
Preparations for key import/export 30ab2c9c46

Key import and export

Introduces two new RPC calls:
* dumpprivkey: retrieve the private key corresponding to an address
* importprivkey: add a private key to your wallet

The private key format is analoguous to the address format. It is
a 51-character base58-encoded string, that includes a version number
and a checksum.

Includes patch by mhanne:
* add optional account parameter for importprivkey, if omitted use default

95d888a6d1

sipa commented at 8:52 PM on December 17, 2011: member

As per Gavin's request, removeprivkey is disabled for now.
gavinandresen referenced this in commit 99a289f531 on Dec 19, 2011
gavinandresen merged this on Dec 19, 2011
gavinandresen closed this on Dec 19, 2011
coblee referenced this in commit f5da900f40 on Jul 17, 2012
kallewoof referenced this in commit 5735322a06 on Oct 4, 2019
Losangelosgenetics referenced this in commit cf9cafd28f on Mar 12, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#32354 tests: Added progress tracker when running fuzz test_runner.py