fix getblocktemplate lock issue #5754

pull jonasschnelli wants to merge 1 commits into bitcoin:master from jonasschnelli:2015/02/rpc_locks_fix_5711 changing 1 files +0 −8

jonasschnelli commented at 3:34 PM on February 4, 2015: contributor

getblocktemplate didn't have a wallet lock before #5711 and IMO there is no need for LEAVE/ENTER critical section.

fix getblocktemplate lock issue

getblocktemplate didn't have a wallet lock before #5711 and IMO there is no need for LEAVE/ENTER critical section.

17115d0a34

laanwj commented at 3:44 PM on February 4, 2015: member

You have it the wrong way around: getblocktemplate did have a wallet lock before #5711 (every RPC call got both the wallet lock and the main lock), but it now no longer takes it, so it also doesn't need to release it. Good catch anyway, ACK.
sdaftuar commented at 3:46 PM on February 4, 2015: member

Looks like this fixes getblocktemplate_longpoll.py, but getblocktemplate_proposals.py fails (as it also does after #5711, I just realized).

EDIT: Actually this other test may have been broken for a while...?
laanwj commented at 4:04 PM on February 4, 2015: member

Hmm - The problem in getblocktemplate_proposals.py indeed seems to be unrelated to #5711. Bitcoin thinks it is in initial block download, and refuses to execute getblocktemplate.
laanwj commented at 4:16 PM on February 4, 2015: member

Verified that the problem with proposals exists at least as far back as 631e698, so I'm going to go ahead and merge this - that problem will have to be solved separately.
laanwj merged this on Feb 4, 2015
laanwj closed this on Feb 4, 2015
laanwj referenced this in commit 1c4e3f99f0 on Feb 4, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors