refactor: move BDB (bitdb / db.h) interaction from init.cpp to wallet.cpp #5758

1. 
   jonasschnelli commented at 8:21 pm on February 4, 2015: contributor

   this will remove db.h from init.cpp
2. 
   jtimon commented at 7:21 pm on February 6, 2015: contributor

   ut ACK
3. laanwj added the label Improvement on Feb 19, 2015
4. 
   jgarzik commented at 2:03 pm on March 11, 2015: contributor

   ut ACK
5. 
   laanwj commented at 9:37 am on March 18, 2015: member

   Nice! Going to test.
6. refactor: move bdb (bitdb) interaction from init.cpp to wallet.cpp

   this will remove db.h from init.cpp

   2578975312
7. in src/init.cpp: in 4d64d99e82 outdated

   873-                InitWarning(msg);
   874-            }
   875-            if (r == CDBEnv::RECOVER_FAIL)
   876-                return InitError(_("wallet.dat corrupt, salvage failed"));
   877-        }
   878+        string warningString;
   

   ---

   ---

   

   laanwj commented at 9:42 am on March 18, 2015:

   Nit: please use std::string. We’d like to get rid of the global using namespaces at some point.

   ---

   

   jonasschnelli commented at 1:14 pm on March 18, 2015:

   Okay. Updated. There are multiple string instantiations without the std:: namespace within init.cpp. I don’t touch these (as well as the one i code-moved) for now.
8. jonasschnelli force-pushed on Mar 18, 2015
9. laanwj referenced this in commit f3948a30cd on Mar 20, 2015
10. 
    laanwj commented at 3:31 pm on March 20, 2015: member

    Merged via 2bb1c87700a80f0b20b4b2cbd68a0d82a18dbcc0 (trivial header conflict fixed)
11. laanwj closed this on Mar 20, 2015

    ---

12. Warrows referenced this in commit 73f711cc2c on Oct 14, 2019
13. Warrows referenced this in commit 7b441e53a4 on Nov 23, 2019
14. MarcoFalke locked this on Sep 8, 2021

Contributors
jonasschnelli jtimon jgarzik laanwj

Labels
Refactoring