No description provided.
Implement BIP66 (0.9) #5762
pull sipa wants to merge 3 commits into bitcoin:0.9 from sipa:bip66_0.9 changing 7 files +211 −4-
sipa commented at 5:27 AM on February 6, 2015: member
-
Implement BIP 66 validation rules and switchover logic ab03660824
-
Backport of some of BIP66's tests 989d49921b
-
sdaftuar commented at 3:21 PM on February 6, 2015: member
First, I tested this code using the same deployment testing script I used on #5713 (submitting ver2 and ver3 blocks, with and without properly DER encoded signatures) over the p2p network to a node running the new code, and the switchover worked as expected.
I did notice that, unlike for the implementation in 0.10, we're not bumping the block version number here. I believe the only effect of that would be that mining nodes must upgrade to 0.10 or higher in order to implement the soft-fork, is that correct? I assume that is the intent?
-
Raise version of created blocks, and enforce DERSIG in mempool 3230b329ea
-
sipa commented at 6:43 PM on February 6, 2015: member
@sdaftuar Eh, no, that was not the intent. Thanks for reviewing!
I've updated the code to produce v3 blocks, and also prevented non-DERSIG from entering the mempool (which should already be impossible due to standardness rules, but belt-and-suspenders...).
-
laanwj commented at 10:54 AM on February 9, 2015: member
utACK
- laanwj merged this on Feb 13, 2015
- laanwj closed this on Feb 13, 2015
- laanwj referenced this in commit 864338a2b2 on Feb 13, 2015
- reddink referenced this in commit 60a96f3b24 on Mar 3, 2016
- reddink referenced this in commit 3032a1a87f on Jul 28, 2016
- reddink referenced this in commit b1b659587d on Aug 4, 2016
- MarcoFalke locked this on Sep 8, 2021
