TRIVIAL: Refactor: inline CTxIn::IsFinal() [ only used in main::IsFinalTx() ] #5769

1. 
   jtimon commented at 4:25 am on February 8, 2015: contributor

   Less lines.
2. Refactor: inline CTxIn::IsFinal() [ only used in main::IsFinalTx() ] d9a270e8cb
3. 
   laanwj commented at 10:22 am on February 9, 2015: member

   NACK. It’s less lines, but less self-documenting. Semantic information as well as encapsulation is lost
4. 
   jtimon commented at 6:19 pm on February 10, 2015: contributor

   Another argument is moving more logic out of the primitives, the same reason why @sipa didn’t wanted primitives/block to depend on pow.o But I don’t have a strong opinion on this, one more nack or lack of interest for a while and I’m closing it.
5. 
   sipa commented at 10:26 pm on February 11, 2015: member

   @laanwj Would making a IsTxInFinal function in main be acceptable?
6. 
   jtimon commented at 8:20 pm on February 13, 2015: contributor

   I think at that point actual documentation would be better than self-documentation. Anyway, I’m closing. We can come back to this after isfinaltx has been moved to consensus.o
7. jtimon closed this on Feb 13, 2015

   ---

8. jtimon referenced this in commit b600459928 on May 16, 2015
9. MarcoFalke locked this on Sep 8, 2021

Contributors
jtimon laanwj sipa