TRIVIAL: Refactor: inline CTxIn::IsFinal() [ only used in main::IsFinalTx() ] #5769

pull jtimon wants to merge 1 commits into bitcoin:master from jtimon:isfinal changing 2 files +1 −6

jtimon commented at 4:25 AM on February 8, 2015: contributor

Less lines.
Refactor: inline CTxIn::IsFinal() [ only used in main::IsFinalTx() ] d9a270e8cb
laanwj commented at 10:22 AM on February 9, 2015: member

NACK. It's less lines, but less self-documenting. Semantic information as well as encapsulation is lost
jtimon commented at 6:19 PM on February 10, 2015: contributor

Another argument is moving more logic out of the primitives, the same reason why @sipa didn't wanted primitives/block to depend on pow.o But I don't have a strong opinion on this, one more nack or lack of interest for a while and I'm closing it.
sipa commented at 10:26 PM on February 11, 2015: member

@laanwj Would making a IsTxInFinal function in main be acceptable?
jtimon commented at 8:20 PM on February 13, 2015: contributor

I think at that point actual documentation would be better than self-documentation. Anyway, I'm closing. We can come back to this after isfinaltx has been moved to consensus.o
jtimon closed this on Feb 13, 2015
jtimon referenced this in commit b600459928 on May 16, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors