autostart shortcut should honor -testnet #5778

issue tykling openend this issue on February 9, 2015
  1. tykling commented at 1:04 pm on February 9, 2015: none
    When checking “Start Bitcoin on system login” the shortcut created doesn’t include -testnet. This means that the shortcut created by the bitcoin-core testnet program starts a mainnet client.
  2. Diapolo commented at 1:30 pm on February 9, 2015: none
    Agreed
  3. Diapolo commented at 8:42 pm on February 14, 2015: none
    @tykling If you are able to, please help testing the patch :).
  4. Diapolo commented at 1:59 pm on February 18, 2015: none
    @tykling Ping again :)… mind testing?
  5. tykling commented at 4:17 pm on February 18, 2015: none

    oh, I accidently left my comment on the first commit, not on the issue :) doh! Here it is:

    0hello,
    1I don't have an easy way of building it so I can't really test it but I do have a couple of comments from looking over the code myself.
    2
    31) I think you need to look at the name of the shortcut created as well, since they have the same name so the testnet autostart shortcut will overwrite the mainnet one, since they are both just named "bitcoin.lnk" - perhaps call one "bitcoin - testnet.lnk" ?
    4
    52) I think the code that makes the autostart stuff for linux around line 690 needs the same fix as the one in your patch.
    6
    7Thanks!
    

    It looks like you handled 1) but doesn’t 2) need fixing as well?

    Thanks!

  6. Diapolo commented at 11:10 am on February 19, 2015: none
    @tykling There are 2 commits, one for Windows and the other for Linux :).
  7. laanwj closed this on Mar 9, 2015

  8. DrahtBot locked this on Sep 8, 2021


tykling Diapolo


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 09:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me