gitian: don't add . to tar list #5790

1. 
   theuni commented at 10:15 PM on February 12, 2015: member

   Since permissions and timestamps are changed for the sake of determinism, . must not be added to the archive. Otherwise, tar may try to modify pwd when extracting.

   Fixes #5789.

   Ping @laanwj: Needs 0.10 cherry-pick.

   Gitian build results: https://bitcoincore.org/cfields/bitcoin-0.10.0rc4-tarfix/bitcoin-0.10.0-linux32.tar.gz https://bitcoincore.org/cfields/bitcoin-0.10.0rc4-tarfix/bitcoin-0.10.0-linux64.tar.gz https://bitcoincore.org/cfields/bitcoin-0.10.0rc4-tarfix/bitcoin-0.10.0-osx64.tar.gz https://bitcoincore.org/cfields/bitcoin-0.10.0rc4-tarfix/bitcoin-0.10.0-osx-unsigned.tar.gz https://bitcoincore.org/cfields/bitcoin-0.10.0rc4-tarfix/bitcoin-0.10.0-win32.zip https://bitcoincore.org/cfields/bitcoin-0.10.0rc4-tarfix/bitcoin-0.10.0-win64.zip

   This changes the osx-unsigned dir structure, but I was planning to do that in the future anyway. It doesn't harm anything.

2. 
   jonasschnelli commented at 10:34 PM on February 12, 2015: contributor

   Looks good. I just started a gitian build. Will be done within ~10mins. https://builds.jonasschnelli.ch/pulls/5790/

3. 
   laanwj commented at 7:17 AM on February 13, 2015: member

   As this is just a change to the gitian descriptors (and just the packaging in that), I suppose it doesn't necessitate another rc. In that case ACK for 0.10.

4. laanwj added this to the milestone 0.10.0 on Feb 13, 2015
5. in contrib/gitian-descriptors/gitian-osx.yml:None in 61d31702c3 outdated

    114 | @@ -115,9 +115,7 @@ script: |
    115 |      cp ${BASEPREFIX}/${i}/native/bin/${i}-codesign_allocate unsigned-app-${i}/codesign_allocate
    116 |      cp ${BASEPREFIX}/${i}/native/bin/${i}-pagestuff unsigned-app-${i}/pagestuff
    117 |      mv dist unsigned-app-${i}
    118 | -    pushd unsigned-app-${i}
    119 | -    find . | sort | tar --no-recursion --mode='u+rw,go+r-w,a+X' --owner=0 --group=0 -c -T - | gzip -9n > ${OUTDIR}/${DISTNAME}-osx-unsigned.tar.gz
    120 | -    popd
    121 | +    find unsigned-app-${i} | sort | tar --no-recursion --mode='u+rw,go+r-w,a+X' --owner=0 --group=0 -c -T - | gzip -9n > ${OUTDIR}/${DISTNAME}-osx-unsigned.tar.gz
   

   ---

   ---

   

   laanwj commented at 7:20 AM on February 13, 2015:

   Mustn't gitian-osx-signer.yml (or detached-sig-apply.sh) also be changed for this change in structure?

   ---

   

   theuni commented at 7:44 AM on February 13, 2015:

   No, see the PR comment. sig creation is all relative to the working dir, and I've been meaning to make it extract to a subdir rather than polluting the current dir anyway. sig application is impartial, as it's also relative to the working dir.

   ---

   

   theuni commented at 7:46 AM on February 13, 2015:

   Actually, hold on that for a sec. On second thought you might be right.

   ---

   

   theuni commented at 7:57 AM on February 13, 2015:

   @laanwj My apologies, this does end up breaking the signing process. I'll revert that change since it's only needed for signing. We can do the cleanups post-0.10.

   Thanks for catching it.

6. laanwj added the label Build system on Feb 13, 2015
7. theuni force-pushed on Feb 13, 2015
8. gitian: don't add . to tar list

   Since permissions and timestamps are changed for the sake of determinism,
   . must not be added to the archive. Otherwise, tar may try to modify pwd when
   extracting.

   0c6ab676ee
9. laanwj merged this on Feb 13, 2015
10. laanwj closed this on Feb 13, 2015

    ---

11. laanwj referenced this in commit c70cdbc393 on Feb 13, 2015
12. laanwj referenced this in commit 047a898317 on Feb 13, 2015
13. reddink referenced this in commit 5d5c03b4c0 on May 27, 2020
14. MarcoFalke locked this on Sep 8, 2021

Contributors

theunijonasschnellilaanwj

Milestone
0.10.0