A pretty frequent source of confusion is the “errors” that appear in debug.log that really shouldn’t be, is there any reason that these shouldn’t be changed to warnings or just informational prints? “Error” just comes on a bit too strong for my liking and doesn’t really reflect what the log print is talking about (rejected transaction, not someone hitting the self destruct button).
Propose:
0ERROR: AcceptToMemoryPool : non-final
Becomes:
0INFO: AcceptToMemoryPool : non-final
I haven’t heard any discussion about such confusion myself. But I agree that ERROR is too strong here because this is part of AcceptToMemoryPool standard behaviour and doesn’t need user’s attention.
One or two days debug.log contains the following here:
0ERROR: AcceptToMemoryPool: inputs already spent
1ERROR: AcceptToMemoryPool: nonstandard transaction: dust
2ERROR: AcceptToMemoryPool: free transaction rejected by rate limiter
None of these messages is an error, but standard information message about tx not being accepted to mempool. Looking at other AcceptToMemoryPool log messages in debug.log, I’d drop “category/level” prefix (ERROR: here) completely and change the message to contain “not accepted”.
ERROR: AcceptToMemoryPool: nonstandard transaction: dust floods, I think we should stop logging messages for incoming transactions by default, whether accepted or rejected. Then add a debug flag for logging these.
