C++ standard #5816

issue ghost opened this issue on February 23, 2015

ghost commented at 12:11 AM on February 23, 2015: none

The C++ standard used remains undocumented in developer-notes.md.
sipa commented at 11:11 AM on February 23, 2015: member

Patches welcome.
ghost commented at 2:58 AM on February 24, 2015: none

;-) So far, the circumstantial evidence points to gnu99 for secp256k1, C++11/C++0x for leveldb and gnu++98/C++98 for bitcoind yet to be switched to C++11.
laanwj commented at 8:40 AM on February 25, 2015: member

Feel free to do this, I don't see this as an issue.
laanwj closed this on Feb 25, 2015
luke-jr commented at 8:49 AM on February 25, 2015: member

AIUI, libsecp256k1 is supposed to be C89, and Bitcoin Core requires at least C++98. Note that C++98 and C++11 are ABI incompatible, so you must use the same one the rest of your OS is compiled with.
ghost commented at 3:30 AM on February 26, 2015: none

@laanwj That's a curious choice. @luke-jr Take a look at /src/secp256k1/configure.ac:25

AC_PROG_CC_C99 if test x"$ac_cv_prog_cc_c99" = x"no"; then AC_MSG_ERROR([c99 compiler support required]) fi
sipa commented at 7:50 AM on February 26, 2015: member

Libsecp256k1 upstream used to be c99, but was converted to strict c89 recently. The copy inside in bitcoin source tree is still c99.
laanwj commented at 8:49 AM on February 26, 2015: member

@21E14 See it from an organizational perspective: there is an infinity of possible improvements possible to the documentation, if there were to be issues for all of them we wouldn't see the forest for the trees.
DrahtBot locked this on Sep 8, 2021

Contributors