Upgrade formatting, readability, consistency in configure.ac. #5836

pull randy-waterhouse wants to merge 8 commits into bitcoin:master from randy-waterhouse:master changing 1 files +377 −366

randy-waterhouse commented at 9:45 AM on February 27, 2015: contributor

Helps tidy ./configure --help readability and consistency also. Needs testing on OSX, windows builds.
jgarzik commented at 2:02 PM on February 27, 2015: contributor

ut ACK -- seems like @theuni trivial tree material
laanwj added the label Build system on Feb 27, 2015
randy-waterhouse commented at 11:43 PM on February 27, 2015: contributor

Adding some more as I work through. @jgarzik should just be trivial if I steer clear of that gray line between formatting and functionality.
randy-waterhouse force-pushed on Mar 2, 2015
randy-waterhouse force-pushed on Mar 4, 2015
Replace # with dnl for global comment consistency in configure.ac.
(Don't use # as also used inside C++ interpreted strings.)
7c9c0f164d
Group functionality with/enable, formatting, comment tidy up configure.ac. 13a33ef200
conf: formatting windows, darwin checks, AC_MSG_ERROR brackets. b4ab7b078b
conf: Formatting for compiler, build flags, base header/libs checks. b04d4a1d54
conf: formatting for sys header/libs, bdb, miniupnpc, boost check logic. 79d40bf58f
conf: formatting ssl/crypto checks, build options checks and outputs. 7644e69ab2
conf: formatting final pass, wrap extra wide lines. bb7fdd5a4c
conf: formatting minor "if" alignments. 38c0798f8a
randy-waterhouse force-pushed on Mar 7, 2015

in configure.ac:None in 38c0798f8a

 289 | -     AC_CHECK_LIB([iphlpapi],      [main],, AC_MSG_ERROR(lib missing))
 290 | -     AC_CHECK_LIB([crypt32],      [main],, AC_MSG_ERROR(lib missing))
 291 | -
 292 | -     # -static is interpreted by libtool, where it has a different meaning.
 293 | -     # In libtool-speak, it's -all-static.
 294 | +     AC_CHECK_LIB([mingwthrd],[main],[], AC_MSG_ERROR([lib missing]))

laanwj commented at 11:10 AM on March 9, 2015:

Although it adds a bit of readability, 'pad with spaces' alignment has the disadvantage that a change on one line makes it necessary to change every line in the table, which makes reviewing changes harder, and can introduce merge conflicts. So I'm generally not in favor of it.

laanwj commented at 11:16 AM on March 9, 2015: member

I'll leave this up to @theuni.

I wonder if there is something akin to clang-format for these files. I'm not against increasing readability, but it is very subjective if it is not possible to automate a certain set of rules. At least try to do this all at once, so that we don't break current pulls affecting configure.ac multiple times.
theuni commented at 2:55 AM on March 10, 2015: member

Sorry for the slow response here, I've been trying to get to the bottom of the AWS block file corruption. I'll review tomorrow.
theuni commented at 3:49 AM on March 12, 2015: member
@laanwj My thoughts exactly. These are all good cleanups, but without any real formatting rules this is basically a never-ending syntax ping-pong. @randy-waterhouse I'm not thrilled about all the whitespace/formatting changes because as I see it one of two things will happen:
1. These will go in, but the next set of changes won't necessarily match.
2. These go in, then we start policing nits in the future (see header includes as an example there).
My preference would be to take the stuff that is more technically correct (# -> dnl and adding missing [ ] for example), and leave the stuff that's just internal formatting alone.

Re-ordering the options makes sense though, I like it when other programs have theirs organized.

Either way, let's take this over to the trivial tree to discuss, to avoid burning c-i cycles here. Please PR to trivial-next in https://github.com/theuni/bitcoin.
randy-waterhouse commented at 7:43 AM on March 13, 2015: contributor

I agree, it is too trivial to waste our time on a back and forward about formatting style preferences. You seem to know what you want and you can take from my mods whatever you like.

The file does need cleaning up though it is in a bit of a state.
randy-waterhouse closed this on Mar 13, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels