travis: attempt fix spurious test failures #5846

pull theuni wants to merge 1 commits into bitcoin:master from theuni:travis-timing changing 1 files +2 −2

theuni commented at 11:17 PM on March 2, 2015: member
There have been a few travis failures lately caused by the comparison tool losing its connection to bitcoind. Sample failure here: https://travis-ci.org/bitcoin/bitcoin/jobs/52724160

I believe I've been able to reproduce locally, and these changes fixed the issue I was experiencing.
- don't use -connect=0.0.0.0. This actually causes attempted connections to 0.0.0.0.
- Don't attempt to discover our IP. That's not needed here.
- With those two removed, the timings are changed such that the previous watchdog didn't always work. Use proper tail/grep semantics to ensure that grep always exits quickly.
Before these changes, I was able to locally reproduce a test failure ~10% of the time. After, I'm unable to see a failure.

travis: attempt fix spurious test failures

- don't use -connect=0.0.0.0. This actually causes attempted connections to
  0.0.0.0.
- Don't attempt to discover our IP. That's not needed here.
- With those two removed, the timings are changed such that the previous
  watchdog didn't always work. Use proper tail/grep semantics to ensure that
  grep always exits quickly.

Before these changes, I was able to locally reproduce a test failure ~10% of
the time. After, I'm unable to see a failure.

686ac0c3d7

theuni commented at 11:55 PM on March 2, 2015: member

Well there's some solid proof to the contrary. Will keep at it.
theuni closed this on Mar 2, 2015
DrahtBot locked this on Sep 8, 2021

Contributors

theuni