Added Caps Lock detection to askpassphrasedialog. #585

pull ghost wants to merge 2 commits into bitcoin:master from changing 6 files +2459 −3

ghost commented at 7:50 PM on October 15, 2011: none

Warns the user, via an added label, if Caps Lock is on while typing in askpassphrasedialog.

in src/qt/askpassphrasedialog.cpp:None in 1357fe5c47 outdated

 215 | +}
 216 | +
 217 | +bool AskPassphraseDialog::eventFilter(QObject *, QEvent *event)
 218 | +{
 219 | +    /* Detect Caps Lock. 
 220 | +     * There is no good OS-indepentent way to check a key state in Qt, but we

gavinandresen commented at 5:32 PM on October 16, 2011:

Spelling nit: OS-independent

gavinandresen commented at 5:32 PM on October 16, 2011: contributor

ACK
laanwj commented at 7:34 PM on October 17, 2011: member

ACK (though see my line comment above, now we're setting text for the labels in both the code and the ui xml, which means it shows up twice in translations)

Also, I'd appreciate if you "rebase -i" this into two commits, one for the Swedish translation and one for the capslock detection.
ghost commented at 10:22 PM on October 17, 2011: none

Oh dear, I messed it up badly :(. Can I fix this somehow? I don't really understand the rebase -i command. Some advice would be very appreciated.
laanwj commented at 5:23 AM on October 18, 2011: member

If you have a merge in the middle, that makes rebase -i work very counter-intuitively. See also: http://notes.envato.com/developers/rebasing-merge-commits-in-git/

Luckily, it seems that the changes itself were not affected. If you don't manage to fix it I'll handle this after the merge window for 0.5.1 starts.
Added Caps Lock check and warning at askpassphrasedialog. 7298ebb432
Added Swedish translation. 77592ee510
ghost assigned alexwaters on Oct 20, 2011
laanwj commented at 8:30 AM on November 13, 2011: member

I've included this into my ui-next branch ( https://github.com/laanwj/bitcoin-qt ) and it will be merged after next release.

This does not include the swedish translation, which I cannot merge as it seems that the file changed under you. Maybe Transifex can help here: https://github.com/laanwj/bitcoin/blob/master/doc/translation_process.md
gavinandresen commented at 3:29 PM on December 19, 2011: contributor

The caps-lock part of this was already pulled.
gavinandresen closed this on Dec 19, 2011
KolbyML referenced this in commit bc86927231 on Sep 4, 2020
rajarshimaitra referenced this in commit 5b64e00535 on Aug 5, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

Labels