test: Revert unittest chain parameters #5871

pull laanwj wants to merge 2 commits into bitcoin:master from laanwj:2015_03_revert_unittest changing 8 files +4 −83
  1. laanwj commented at 3:33 pm on March 9, 2015: member

    UNITTEST parameters are not used by any current tests, and the model (modifyable parameters) is inconvenient when unit-testing in random order. As they are stored in a global structure every test would have to (re)set up its own parameters. This reverts #5030.

    For consistency it is better, too, to test with the actual MAIN parameters and not a variation.

    Also removes related (and unused) fSkipProofOfWork parameter.

  2. test: Remove UNITTEST params
    UNITTEST parameter are not used by any current tests, and the model
    (modifyable parameters) is inconvenient when unit-testing. As
    they are stored in a global structure eevery test
    would have to (re)set up its own parameters.
    
    For consistency it is also better to test with MAIN parameters.
    59bd89f116
  3. test: remove fSkipProofOfWork
    Not used, and REGTEST already allows creating blocks at
    the lowerst possible difficulty.
    3aa0130b96
  4. laanwj added the label Tests on Mar 9, 2015
  5. jtimon commented at 10:41 am on March 10, 2015: contributor
    ut ACK
  6. sipa commented at 12:07 pm on March 10, 2015: member
    utACK
  7. jgarzik commented at 1:53 pm on March 11, 2015: contributor
    ut ACK
  8. laanwj merged this on Mar 11, 2015
  9. laanwj closed this on Mar 11, 2015

  10. laanwj referenced this in commit e564e63ef0 on Mar 11, 2015
  11. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 09:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me