tests: add a BasicTestingSetup and apply to all tests #5883

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2015_03_fix_test_scattering changing 35 files +90 −36

laanwj commented at 8:38 AM on March 12, 2015: member

Make sure that chainparams and logging is properly initialized. Doing this for every test may be overkill, but this initialization is so simple that that does not matter.

This should fix the travis issues.

tests: add a BasicTestingSetup and apply to all tests

Make sure that chainparams and logging is properly initialized. Doing
this for every test may be overkill, but this initialization is so
simple that that does not matter.

This should fix the travis issues.

92fd887fd4

laanwj force-pushed on Mar 12, 2015
jonasschnelli commented at 8:51 AM on March 12, 2015: contributor

Tested locally. Worked fine. Let's see what travis means. Also started a gitian build to get more test env. diversity.
laanwj added the label Tests on Mar 12, 2015
Diapolo commented at 9:14 AM on March 12, 2015: none

This doesn't apply to Qt tests?
laanwj commented at 9:20 AM on March 12, 2015: member

@diapolo I don't think so, nothing changed there recently did it?
Diapolo commented at 9:24 AM on March 12, 2015: none

I was just asking, because it seems you updated all core testfiles, but not the Qt ones.
laanwj commented at 9:32 AM on March 12, 2015: member

@diapolo Just checked. Last change to qt tests is 5 weeks ago and had to do with payment requests. There were no test reordering or initialization changes for qt.
Diapolo commented at 9:39 AM on March 12, 2015: none

Alright, thanks for verifying :)!
laanwj merged this on Mar 12, 2015
laanwj closed this on Mar 12, 2015
laanwj referenced this in commit 164d7b674b on Mar 12, 2015
jonasschnelli commented at 10:02 AM on March 12, 2015: contributor
For the records. Gitian was also happy with this:
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels