font size too small in debug console. #5897

microcai commented at 11:08 AM on March 14, 2015: none

I build with Qt5.

UI is fine with Qt5. normal UI works out-of-box for HIDPI monitor, except debug console. the font is very small, and can not by adjusted by Ctr+mousewheel or Ctr+Key_Plus

because Mac uses pixel scale, so the UI might be usable on retina mac, but on Linux, there is no PixelRatio ( aka , always = 1.0) so the font should not be specified in fixed pixel size. but use QFontMetrics, or, just just use "points" .

jonasschnelli commented at 11:11 AM on March 14, 2015: contributor

@microcai could you post a screenshot? You are saying that you run on an HiDPI enabled linux window manager? Qt should handle the pixel ration (>=Qt5) for HiDPI... but never checked in detail because HiDPI is still not widely used on linux.

microcai commented at 11:17 AM on March 14, 2015: none

NO, Qt does not use pixel ratio on linux, even on HiDPI windows. this only for Mac. mornal app should best just use "point" to specify the font size.

screenshot_bitcoin

jonasschnelli commented at 11:20 AM on March 14, 2015: contributor

It looks like you are running 0.10 not the master. But this should not make a big difference. I just see other HiDPI issues which might need to take upstream to Qt. Example: scrollbar-width, icon-size. Could you post some more screenshots of other screen situations like sending coins, etc.?

jonasschnelli commented at 11:21 AM on March 14, 2015: contributor

Maybe try running the master branch by compiling bitcoin-qt yourself or using a nightly-build: https://builds.jonasschnelli.ch/nightlybuilds/2015-03-14/

jonasschnelli commented at 11:33 AM on March 14, 2015: contributor

found the potential issue. At least it was marked as //todo. https://github.com/bitcoin/bitcoin/blob/master/src/qt/rpcconsole.cpp#L360 I think it could be changed to font-size: 1em; or similar. But strange that OSX does blow up the font to 24px (on screen; non HiDPI converted) but linux not.

microcai commented at 11:36 AM on March 14, 2015: none

other screens are perfectly fine with hidpi settings. font size are all normal. the rpcconsole is currently the only place I see small font. btw, the splash screen is also not DPI-aware, but that is completely fine.

jonasschnelli commented at 11:38 AM on March 14, 2015: contributor

Thanks for reporting! The splash screen is not DPI aware in 0.10 but it is in master. Could you try master for a splash-screen check on HiDPI linux (maybe post the screenshot)?

jonasschnelli referenced this in commit dff60132a5 on Mar 14, 2015

microcai commented at 11:44 AM on March 14, 2015: none

I'm trying 0.10 with the mentioned line removed screenshot_bitcoin1

now it works fine.

jonasschnelli commented at 11:46 AM on March 14, 2015: contributor

okay...nice. you might also check #5898.

luke-jr commented at 2:21 PM on March 14, 2015: member

What does font-size:1em do? Isn't that the same as not setting it?

jonasschnelli referenced this in commit 046bc52766 on Mar 15, 2015

jonasschnelli referenced this in commit c8168331a2 on Mar 27, 2015

laanwj closed this on Mar 30, 2015

MarcoFalke locked this on Sep 8, 2021