[QA] add multisig rpc tests #5958

pull jonasschnelli wants to merge 1 commits into bitcoin:master from jonasschnelli:2015/04/multisig_rpc_tests changing 2 files +84 −8

jonasschnelli commented at 1:14 PM on April 1, 2015: contributor

Wrote this during some educational tests. Could also be useful for others trying to get more into multisig. And tests will always help to improve maintainability.
gavinandresen commented at 2:57 PM on April 1, 2015: contributor

Tested ACK: more tests is good.

RE: having a 2-of-3 count as spendable: WAAAY back when I implemented P2SH support to the wallet I decided that the safest thing to do would be to only count as spendable outputs for which you had ALL of the keys.

The double-spend / conflicting transaction code is much better now, so I'm not worried any more, and would be in favor of changing to counting any output for which you have enough keys to fully sign count as spendable (assuming we have good regression tests like this one to go along with that change, of course).
jgarzik commented at 5:18 AM on April 5, 2015: contributor

ut ACK
jgarzik added the label Tests on Apr 5, 2015
jonasschnelli force-pushed on May 2, 2015
jonasschnelli commented at 9:36 AM on May 2, 2015: contributor

Rebased and adapted setgenerate() to .generate(). Hope for a quick merge.
jonasschnelli force-pushed on May 7, 2015
jonasschnelli force-pushed on May 7, 2015
jonasschnelli force-pushed on May 7, 2015
paveljanik commented at 9:03 AM on May 7, 2015: contributor

utACK. Please fix the typo in the commit message (mutlisig).
[QA] add multisig rpc tests 231072fe7b
jonasschnelli force-pushed on May 7, 2015
jonasschnelli renamed this:
~~[QA] add mutlisig rpc tests~~
[QA] add multisig rpc tests
on May 7, 2015
jonasschnelli commented at 9:06 AM on May 7, 2015: contributor

@paveljanik: fixed. Thanks @paveljanik!
laanwj merged this on May 7, 2015
laanwj closed this on May 7, 2015
laanwj referenced this in commit 9ef00c363d on May 7, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels