Add additional block index consistency checks #5959

1. 
   sdaftuar commented at 7:37 pm on April 1, 2015: member

   This adds more tests to CheckBlockIndex:

   • HAVE_DATA is true iff nTx > 0
   • BLOCK_VALID_TRANSACTIONS is true iff nTx > 0
   • BLOCK_VALID_TRANSACTIONS is true for a block and all parents iff nChainTx > 0
2. Add additional block index consistency checks

   This adds more tests to CheckBlockIndex:
   - HAVE_DATA is true iff nTx > 0
   - BLOCK_VALID_TRANSACTIONS is true iff nTx > 0
   - BLOCK_VALID_TRANSACTIONS is true for a block and all parents iff
     nChainTx > 0

   ede379f780
3. 
   sipa commented at 7:57 pm on April 1, 2015: member

   utACK
4. 
   laanwj commented at 6:56 am on April 8, 2015: member

   utACK
5. laanwj merged this on Apr 8, 2015
6. laanwj closed this on Apr 8, 2015

   ---

7. laanwj referenced this in commit a0bfc69541 on Apr 8, 2015
8. MarcoFalke locked this on Sep 8, 2021

Contributors
sdaftuar sipa laanwj