Alter assumptions in CCoinsViewCache::BatchWrite #5967

1. 
   morcos commented at 4:47 pm on April 3, 2015: member

   Previously it would break if you flushed a parent cache while there was a child cache referring to it. This change will allow the flushing of parent caches.

   It also modifies the unit test to include flushing of intermediate caches.

2. laanwj added the label UTXO Db and Indexes on Apr 8, 2015
3. morcos closed this on Apr 23, 2015

   ---

4. morcos deleted the branch on Apr 23, 2015
5. morcos restored the branch on Apr 23, 2015
6. morcos reopened this on Apr 23, 2015

   ---

7. in src/coins.cpp: in e4484f476c outdated

   147-                    // cache does have (a non-pruned) one. Move the data up, and
   148-                    // mark it as fresh (if the grandparent did have it, we
   149-                    // would have pulled it in at first GetCoins).
   150-                    assert(it->second.flags & CCoinsCacheEntry::FRESH);
   151+                // The parent cache does not have an entry, while the child does
   152+                // We can ignore it if its both FRESH and pruned in the child
   

   ---

   ---

   

   sipa commented at 2:44 pm on April 27, 2015:

   Nit: s/its/it’s/
8. 
   sipa commented at 2:45 pm on April 27, 2015: member

   Untested ACK, but the unit test should cover it.
9. morcos force-pushed on May 18, 2015
10. morcos force-pushed on May 18, 2015
11. 
    morcos commented at 3:53 pm on May 18, 2015: member

    Needed rebase (nit fixed)
12. 
    MarcoFalke commented at 10:28 pm on November 10, 2015: member

    @morcos This needs an update/rebase?
13. morcos force-pushed on Nov 12, 2015
14. 
    morcos commented at 2:09 am on November 12, 2015: member

    rebased
15. 
    sipa commented at 5:41 pm on November 13, 2015: member

    Code review & lightly tested ACK.
16. Alter assumptions in CCoinsViewCache::BatchWrite

    Previously it would break if you flushed a parent cache while there was a child cache referring to it.  This change will allow the flushing of parent caches.

    072e2f8644
17. morcos force-pushed on Nov 18, 2015
18. 
    morcos commented at 5:15 pm on November 18, 2015: member

    This was rebased to modify the new unit test added from #6932 as well.
19. laanwj merged this on Nov 27, 2015
20. laanwj closed this on Nov 27, 2015

    ---

21. laanwj referenced this in commit 05d591839f on Nov 27, 2015
22. random-zebra referenced this in commit 68df9a7d5b on Aug 8, 2020
23. MarcoFalke locked this on Sep 8, 2021

Contributors
morcos sipa MarcoFalke

Labels
UTXO Db and Indexes