strCommand == "tx": ignore until initial block download is complete #597

issue dmgores opened this issue on October 29, 2011
  1. dmgores commented at 6:34 PM on October 29, 2011: none

    strCommand == "tx": ignore until initial block download is complete.

    Why? No need to process new transactions that would go in the new block that is being generated when you do not have the entire chain. This would save some CPU cycles and some debug log length.

    In my suggested change (C#), I add the initial block download check after adding the CInv to the node's inventory:

                CInv inv = new CInv(ppszTypeName.tx, tx.GetHash());
                pfrom.AddInventoryKnown(inv);
    

    + if (CBlock.IsInitialBlockDownload() || CTransaction.IsOrphanTX(tx.GetHash()))

    •                return true;
                bool fMissingInputs = false;
                if (tx.AcceptToMemoryPool(true, ref fMissingInputs))...
    
  2. laanwj commented at 2:41 PM on November 4, 2013: member

    Closing this, as it never sparked any discussion and it seems no immediate issue.

  3. laanwj closed this on Nov 4, 2013

  4. ptschip referenced this in commit eed7834261 on May 19, 2017
  5. sipa referenced this in commit cc05fa919a on Mar 30, 2019
  6. sipa referenced this in commit 1e32413e52 on Mar 30, 2019
  7. sipa referenced this in commit 54245985fb on Mar 31, 2019
  8. sipa referenced this in commit 3fe71bbd95 on Apr 2, 2019
  9. LongShao007 referenced this in commit 3d9a3d2063 on Jul 15, 2019
  10. LongShao007 referenced this in commit 8af66f3427 on Jul 15, 2019
  11. LongShao007 referenced this in commit 807f206f73 on Jul 15, 2019
  12. fjahr referenced this in commit 05362ee042 on Jul 24, 2019
  13. kallewoof referenced this in commit c866f52e2a on Oct 4, 2019
  14. KolbyML referenced this in commit bc86927231 on Sep 4, 2020
  15. backpacker69 referenced this in commit ef89673ace on Mar 28, 2021
  16. rajarshimaitra referenced this in commit bd68075856 on Aug 5, 2021
  17. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 06:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me