Settings should be stored only in bitcoin.conf so the wallet.dat is only a wallet.
We would need...
Any thoughts on this?
Rewriting user-created config files is always error-prone and tricky (you don't want to overwrite a user's carefully crafted bitcoin.conf).
And it seems like the desire to do this is really some other feature in disguise (like backing up and encrypting private keys).
I do like the idea of RPC to change bitcoin settings. Although some of the settings are only currently set-able on startup.
Be careful of the downgrade + upgrade scenario.
Consider using an existing configuration repository like gconf.
I think this proposal has merit.
I was quite surprised to find, from reading the source code, that the wallet contains both money and configuration data. Keeping the two sets of data separate makes much more sense than lumping them together into a single file.
If it's implemented correctly, there should be no issues with overwriting any of the users' changes.
I like this idea. I don't necessarily say that the options should be re-written to bitcoin.conf, some other config file is OK too, but they should not be in the wallet.
This will become especially apparent if we implement multiple wallet support.
Settings were moved out of the wallet into the Qt settings file.