use SUBDIRS to include libsecp256k1 #6026

pull Mischi wants to merge 1 commits into bitcoin:master from Mischi:fix-install-target-libsecp256k1 changing 1 files +1 −1
  1. Mischi commented at 7:12 PM on April 18, 2015: contributor

    Hi, i'm trying to update OpenBSD's WIP port of Bitcoin to the latest 0.10.1rc2 and noticed that libsecp256k1.* is not installed when make install is called.

    After reading Automake/Directories, i think we should use SUBDIRS instead of DIST_SUBDIRS to call recursive targets like install correctly? :confused:

    Below is the output before/after applying this patch.

    Cheers, Fabian

    BEFORE

    Making install in src
gmake[1]: Entering directory '/usr/pobj/ports/bitcoin-0.10.1rc2/bitcoin-0.10.1rc2/src'
gmake[2]: Entering directory '/usr/pobj/ports/bitcoin-0.10.1rc2/bitcoin-0.10.1rc2/src'
gmake[3]: Entering directory '/usr/pobj/ports/bitcoin-0.10.1rc2/bitcoin-0.10.1rc2/src'
 mkdir -p '/usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/lib'
 /usr/local/bin/libtool   --mode=install /usr/pobj/ports/bitcoin-0.10.1rc2/bin/install -c    libbitcoinconsensus.la '/usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/lib'
libtool: install: /usr/pobj/ports/bitcoin-0.10.1rc2/bin/install -c -m 644 .libs/libbitcoinconsensus.so.0.0 /usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/lib/libbitcoinconsensus.so.0.0
libtool: install: /usr/pobj/ports/bitcoin-0.10.1rc2/bin/install -c -m 644 .libs/libbitcoinconsensus.lai /usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/lib/libbitcoinconsensus.la
libtool: install: /usr/pobj/ports/bitcoin-0.10.1rc2/bin/install -c .libs/libbitcoinconsensus.a /usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/lib/libbitcoinconsensus.a
libtool: install: chmod 644 /usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/lib/libbitcoinconsensus.a
libtool: install: ranlib -t /usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/lib/libbitcoinconsensus.a
libtool: install: warning: remember to run `libtool --finish /usr/local/lib'
 mkdir -p '/usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/bin'
  /usr/local/bin/libtool   --mode=install /usr/pobj/ports/bitcoin-0.10.1rc2/bin/install -c -s  -m 755 bitcoind bitcoin-cli bitcoin-tx qt/bitcoin-qt '/usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/bin'
libtool: install: /usr/pobj/ports/bitcoin-0.10.1rc2/bin/install -c -m 755 -s .libs/bitcoind /usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/bin/bitcoind
libtool: install: /usr/pobj/ports/bitcoin-0.10.1rc2/bin/install -c -m 755 -s bitcoin-cli /usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/bin/bitcoin-cli
libtool: install: /usr/pobj/ports/bitcoin-0.10.1rc2/bin/install -c -m 755 -s .libs/bitcoin-tx /usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/bin/bitcoin-tx
libtool: install: /usr/pobj/ports/bitcoin-0.10.1rc2/bin/install -c -m 755 -s qt/.libs/bitcoin-qt /usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/bin/bitcoin-qt
 mkdir -p '/usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/include'
 /usr/pobj/ports/bitcoin-0.10.1rc2/bin/install -c  -m 644 script/bitcoinconsensus.h '/usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/include'
gmake[3]: Leaving directory '/usr/pobj/ports/bitcoin-0.10.1rc2/bitcoin-0.10.1rc2/src'
gmake[2]: Leaving directory '/usr/pobj/ports/bitcoin-0.10.1rc2/bitcoin-0.10.1rc2/src'
gmake[1]: Leaving directory '/usr/pobj/ports/bitcoin-0.10.1rc2/bitcoin-0.10.1rc2/src'
gmake[1]: Entering directory '/usr/pobj/ports/bitcoin-0.10.1rc2/bitcoin-0.10.1rc2'
gmake[2]: Entering directory '/usr/pobj/ports/bitcoin-0.10.1rc2/bitcoin-0.10.1rc2'
gmake[2]: Nothing to be done for 'install-exec-am'.
gmake[2]: Nothing to be done for 'install-data-am'.
gmake[2]: Leaving directory '/usr/pobj/ports/bitcoin-0.10.1rc2/bitcoin-0.10.1rc2'
gmake[1]: Leaving directory '/usr/pobj/ports/bitcoin-0.10.1rc2/bitcoin-0.10.1rc2'

    AFTER

    Making install in src
gmake[1]: Entering directory '/usr/pobj/ports/bitcoin-0.10.1rc2/bitcoin-0.10.1rc2/src'
Making install in secp256k1
gmake[2]: Entering directory '/usr/pobj/ports/bitcoin-0.10.1rc2/bitcoin-0.10.1rc2/src/secp256k1'
gmake[3]: Entering directory '/usr/pobj/ports/bitcoin-0.10.1rc2/bitcoin-0.10.1rc2/src/secp256k1'
 mkdir -p '/usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/lib'
 /usr/local/bin/libtool   --mode=install /usr/pobj/ports/bitcoin-0.10.1rc2/bin/install -c    libsecp256k1.la '/usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/lib'
libtool: install: /usr/pobj/ports/bitcoin-0.10.1rc2/bin/install -c -m 644 .libs/libsecp256k1.so.0.0 /usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/lib/libsecp256k1.so.0.0
libtool: install: /usr/pobj/ports/bitcoin-0.10.1rc2/bin/install -c -m 644 .libs/libsecp256k1.lai /usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/lib/libsecp256k1.la
libtool: install: /usr/pobj/ports/bitcoin-0.10.1rc2/bin/install -c .libs/libsecp256k1.a /usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/lib/libsecp256k1.a
libtool: install: chmod 644 /usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/lib/libsecp256k1.a
libtool: install: ranlib -t /usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/lib/libsecp256k1.a
libtool: install: warning: remember to run `libtool --finish /usr/local/lib'
 mkdir -p '/usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/include'
 /usr/pobj/ports/bitcoin-0.10.1rc2/bin/install -c  -m 644 include/secp256k1.h '/usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/include'
 mkdir -p '/usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/lib/pkgconfig'
 /usr/pobj/ports/bitcoin-0.10.1rc2/bin/install -c  -m 644 libsecp256k1.pc '/usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/lib/pkgconfig'
gmake[3]: Leaving directory '/usr/pobj/ports/bitcoin-0.10.1rc2/bitcoin-0.10.1rc2/src/secp256k1'
gmake[2]: Leaving directory '/usr/pobj/ports/bitcoin-0.10.1rc2/bitcoin-0.10.1rc2/src/secp256k1'
gmake[2]: Entering directory '/usr/pobj/ports/bitcoin-0.10.1rc2/bitcoin-0.10.1rc2/src'
gmake[3]: Entering directory '/usr/pobj/ports/bitcoin-0.10.1rc2/bitcoin-0.10.1rc2/src'
 mkdir -p '/usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/lib'
 /usr/local/bin/libtool   --mode=install /usr/pobj/ports/bitcoin-0.10.1rc2/bin/install -c    libbitcoinconsensus.la '/usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/lib'
libtool: install: /usr/pobj/ports/bitcoin-0.10.1rc2/bin/install -c -m 644 .libs/libbitcoinconsensus.so.0.0 /usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/lib/libbitcoinconsensus.so.0.0
libtool: install: /usr/pobj/ports/bitcoin-0.10.1rc2/bin/install -c -m 644 .libs/libbitcoinconsensus.lai /usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/lib/libbitcoinconsensus.la
libtool: install: /usr/pobj/ports/bitcoin-0.10.1rc2/bin/install -c .libs/libbitcoinconsensus.a /usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/lib/libbitcoinconsensus.a
libtool: install: chmod 644 /usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/lib/libbitcoinconsensus.a
libtool: install: ranlib -t /usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/lib/libbitcoinconsensus.a
libtool: install: warning: remember to run `libtool --finish /usr/local/lib'
 mkdir -p '/usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/bin'
  /usr/local/bin/libtool   --mode=install /usr/pobj/ports/bitcoin-0.10.1rc2/bin/install -c -s  -m 755 bitcoind bitcoin-cli bitcoin-tx qt/bitcoin-qt '/usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/bin'
libtool: install: /usr/pobj/ports/bitcoin-0.10.1rc2/bin/install -c -m 755 -s .libs/bitcoind /usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/bin/bitcoind
libtool: install: /usr/pobj/ports/bitcoin-0.10.1rc2/bin/install -c -m 755 -s bitcoin-cli /usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/bin/bitcoin-cli
libtool: install: /usr/pobj/ports/bitcoin-0.10.1rc2/bin/install -c -m 755 -s .libs/bitcoin-tx /usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/bin/bitcoin-tx
libtool: install: /usr/pobj/ports/bitcoin-0.10.1rc2/bin/install -c -m 755 -s qt/.libs/bitcoin-qt /usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/bin/bitcoin-qt
 mkdir -p '/usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/include'
 /usr/pobj/ports/bitcoin-0.10.1rc2/bin/install -c  -m 644 script/bitcoinconsensus.h '/usr/pobj/ports/bitcoin-0.10.1rc2/fake-amd64/usr/local/include'
gmake[3]: Leaving directory '/usr/pobj/ports/bitcoin-0.10.1rc2/bitcoin-0.10.1rc2/src'
gmake[2]: Leaving directory '/usr/pobj/ports/bitcoin-0.10.1rc2/bitcoin-0.10.1rc2/src'
gmake[1]: Leaving directory '/usr/pobj/ports/bitcoin-0.10.1rc2/bitcoin-0.10.1rc2/src'
gmake[1]: Entering directory '/usr/pobj/ports/bitcoin-0.10.1rc2/bitcoin-0.10.1rc2'
gmake[2]: Entering directory '/usr/pobj/ports/bitcoin-0.10.1rc2/bitcoin-0.10.1rc2'
gmake[2]: Nothing to be done for 'install-exec-am'.
gmake[2]: Nothing to be done for 'install-data-am'.
gmake[2]: Leaving directory '/usr/pobj/ports/bitcoin-0.10.1rc2/bitcoin-0.10.1rc2'
gmake[1]: Leaving directory '/usr/pobj/ports/bitcoin-0.10.1rc2/bitcoin-0.10.1rc2'
  2. use SUBDIRS to include libsecp256k1
    Use SUBDIRS instead of DIST_SUBDIRS to call recursive targets like
install correctly.
    36e8389dbf
  3. Mischi commented at 7:21 PM on April 18, 2015: contributor

    Maybe @theuni or @sipa will know ...

  4. laanwj commented at 10:57 AM on April 20, 2015: member

    secp256k1 shouldn't be installed as part of bitcoin, like leveldb and json-spirit it is included only as a dependency to bitcoin. Use the upstream repository if you want to install secp256k1 as a library: https://github.com/bitcoin/secp256k1/ . This will also yield a shared library and will be more up-to-date.

  5. laanwj added the label Build system on Apr 20, 2015
  6. theuni commented at 9:12 PM on April 20, 2015: member

    Agreed. DIST_SUBDIRS was used for the reasons that @laanwj pointed out.

  7. laanwj closed this on Apr 21, 2015
  8. DrahtBot locked this on Sep 8, 2021
Contributors
Mischilaanwjtheuni
Labels
Build system
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-29 03:16 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me