use constant reference as param in ConnectThroughProxy() #6054

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:netbase_const_ref changing 1 files +2 −2

Diapolo commented at 1:06 PM on April 23, 2015: none

No description provided.
jonasschnelli commented at 1:11 PM on April 23, 2015: contributor

Why not also changing bool static Socks5(string strDest, int port, const ProxyCredentials *auth, SOCKET& hSocket)'s first arg to const string& strDest?
Diapolo commented at 1:12 PM on April 23, 2015: none

Just forgot to add it here :) the change is already in my local branch... Edit: @jonasschnelli There it IS!

in src/netbase.cpp:None in cb06f10e5f outdated

 292 | @@ -293,7 +293,7 @@ struct ProxyCredentials
 293 |  };
 294 |  
 295 |  /** Connect using SOCKS5 (as described in RFC1928) */
 296 | -bool static Socks5(string strDest, int port, const ProxyCredentials *auth, SOCKET& hSocket)
 297 | +bool static Socks5(const std::string& strDest, int port, const ProxyCredentials *auth, SOCKET& hSocket)

laanwj commented at 12:30 PM on April 24, 2015:

if we're micro-managing this line anyway, maybe can change it to static bool instead of bool static, having static first that seems to be a more common order in our source

jgarzik commented at 1:03 PM on April 24, 2015: contributor

ACK once @laanwj 's nit is sorted.
laanwj added the label Improvement on Apr 24, 2015

use const reference as param in ConnectThroughProxy/Socks5

- also ensure code style conformance by replacing bool static with static bool

d1af89e655

Diapolo commented at 12:46 PM on April 28, 2015: none

Updated to include @laanwj's nit.
sipa commented at 1:57 PM on April 28, 2015: member

ACK
sipa merged this on Apr 28, 2015
sipa closed this on Apr 28, 2015
sipa referenced this in commit 9e06be2802 on Apr 28, 2015
Diapolo deleted the branch on May 19, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels