autoprune minor post-merge improvements #6058

pull jonasschnelli wants to merge 2 commits into bitcoin:master from jonasschnelli:2015/04/autoprune_info changing 2 files +15 −0

jonasschnelli commented at 8:12 PM on April 24, 2015: contributor
- Adds information about whether we are in pruned mode or not to RPC getblockchaininfo().
- Produces appropriate response when trying to access a pruned block over REST and RPC.
sipa commented at 8:13 PM on April 24, 2015: member

Please don't extend getinfo. We want to deprecate it.
jonasschnelli force-pushed on Apr 25, 2015
jonasschnelli renamed this:
~~add autoprune information to RPC "getinfo"~~
add autoprune information to RPC "getblockchaininfo"
on Apr 25, 2015
jonasschnelli force-pushed on Apr 25, 2015
jonasschnelli force-pushed on Apr 25, 2015
jonasschnelli commented at 6:31 PM on April 25, 2015: contributor

@sipa: right. You already told me that on IRC. My mistake, sorry. Moved information to getblockchaininfo().
add autoprune information to RPC "getblockchaininfo" 1b2e555593

in src/rpcblockchain.cpp:None in 76c2a4c7f0 outdated

 491 | @@ -492,6 +492,15 @@ Value getblockchaininfo(const Array& params, bool fHelp)
 492 |      obj.push_back(Pair("difficulty",            (double)GetDifficulty()));
 493 |      obj.push_back(Pair("verificationprogress",  Checkpoints::GuessVerificationProgress(chainActive.Tip())));
 494 |      obj.push_back(Pair("chainwork",             chainActive.Tip()->nChainWork.GetHex()));
 495 | +    obj.push_back(Pair("autoprune",             fPruneMode));

sipa commented at 9:19 PM on April 26, 2015:

I think we're abolishing the name "autoprune". Can you just call it "pruned" or something?

jonasschnelli force-pushed on Apr 26, 2015
jgarzik commented at 9:31 PM on April 26, 2015: contributor

ut ACK
jonasschnelli renamed this:
~~add autoprune information to RPC "getblockchaininfo"~~
autoprune minor post-merge improvements
on Apr 27, 2015
jonasschnelli commented at 3:22 AM on April 27, 2015: contributor

Renamed and added some error handling for REST and RPC when trying to access a pruned block.
jonasschnelli force-pushed on Apr 27, 2015
sipa commented at 9:05 AM on April 27, 2015: member

utACK
laanwj added the label Improvement on Apr 29, 2015
laanwj commented at 10:14 AM on April 29, 2015: member

utACK after @sdaftuar 's nit fixed. The error message specifically mentions "pruned", so it should be sure that's actually the case.
jonasschnelli force-pushed on Apr 29, 2015
jonasschnelli commented at 11:27 AM on April 29, 2015: contributor

Agreed with @sdaftuar. Corrected prune mode test.
jonasschnelli force-pushed on May 2, 2015
appropriate response when trying to get a block in pruned mode 03c56872b5
jonasschnelli force-pushed on May 11, 2015
laanwj merged this on May 11, 2015
laanwj closed this on May 11, 2015
laanwj referenced this in commit 7e0e7f823f on May 11, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels