Add English translation to fix plural(s). #606

pull dooglus wants to merge 1 commits into bitcoin:master from dooglus:add-english-translation changing 2 files +2301 −0
  1. dooglus commented at 6:59 PM on November 4, 2011: contributor

    The source code uses code like: text = tr("%n hour(s) ago","",secs/(60*60)); to produce nice looking plurals in any language we translate to, but we don't have an English translation, and so the user sees "1 hour(s) ago".

    This commit adds an English translation which defines the correct plural strings for the 6 strings that need them:

    ./src/qt/transactiontablemodel.cpp: status = tr("Open for %n block(s)","",wtx->status.open_for); ./src/qt/bitcoingui.cpp: labelConnectionsIcon->setToolTip(tr("%n active connection(s) to Bitcoin network", "", count)); ./src/qt/bitcoingui.cpp: text = tr("%n second(s) ago","",secs); ./src/qt/bitcoingui.cpp: text = tr("%n minute(s) ago","",secs/60); ./src/qt/bitcoingui.cpp: text = tr("%n hour(s) ago","",secs/(60_60)); ./src/qt/bitcoingui.cpp: text = tr("%n day(s) ago","",secs/(60_60*24));

    http://doc.qt.nokia.com/qq/qq19-plurals.html says: "To obtain a more natural English text, you need to load an English translation."

  2. laanwj commented at 7:54 PM on November 4, 2011: member

    ACK, good idea.

    However, it seems that you forgot to add the new translation to the bitcoin.qrc file :)

  3. Add English translation to fix plural(s). 2989b462a5
  4. dooglus commented at 8:07 PM on November 4, 2011: contributor

    You're right. I've made a new commit with that change too. There's another translation needing plurals, too, which I've also added:

    ./src/qt/transactiontablemodel.cpp: status += tr("Mined balance will be available in %n more blocks", "",

    I was searching for the '(s)' text before, and so missed this one.

  5. laanwj referenced this in commit 81a28d7a6f on Nov 4, 2011
  6. laanwj merged this on Nov 4, 2011
  7. laanwj closed this on Nov 4, 2011

  8. coblee referenced this in commit 13fa5474f1 on Jul 17, 2012
  9. ptschip referenced this in commit afe96b07ef on May 22, 2017
  10. sipa referenced this in commit 54245985fb on Mar 31, 2019
  11. sipa referenced this in commit 3fe71bbd95 on Apr 2, 2019
  12. LongShao007 referenced this in commit 3d9a3d2063 on Jul 15, 2019
  13. LongShao007 referenced this in commit 8af66f3427 on Jul 15, 2019
  14. LongShao007 referenced this in commit 807f206f73 on Jul 15, 2019
  15. fjahr referenced this in commit 4d01bc2d9c on Jul 24, 2019
  16. kallewoof referenced this in commit 0de7d05d00 on Oct 4, 2019
  17. kallewoof referenced this in commit c866f52e2a on Oct 4, 2019
  18. backpacker69 referenced this in commit ef89673ace on Mar 28, 2021
  19. DrahtBot locked this on Sep 8, 2021
Contributors

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-16 00:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me