P2P testing cleanups #6089

pull sdaftuar wants to merge 2 commits into bitcoin:master from sdaftuar:p2p-testing-cleanups changing 2 files +21 −12
  1. sdaftuar commented at 9:19 PM on April 30, 2015: member

    @jonasschnelli The first commit should fix the asyncore issue you encountered. I investigated what happens inside asyncore when it uses select instead of poll, and the bug is a subtle race condition: it appears to me that it's not safe to call close() while asyncore.loop() is running when using select(). Merely increasing the timeout would only reduce the likelihood of the bug triggering, not eliminate it, so instead I reworked the disconnect logic to happen outside of asyncore.loop() to eliminate that bug altogether.

    The second commit takes invalidblockrequest.py out of travis until I am able to offer up a proper fix to a different race condition that could cause that test to spuriously fail -- that should be soon, but I worry that this could break travis for people in the meantime. Thanks again @jonasschnelli for reporting this in #5981.

  2. Fix mininode disconnections to work with select ef3281750d
  3. Don't run invalidblockrequest.py in travis until race condition is fixed 5487975ca3
  4. laanwj added the label Tests on May 1, 2015
  5. laanwj commented at 12:53 PM on May 1, 2015: member

    utACK

  6. jonasschnelli commented at 6:17 PM on May 1, 2015: contributor

    tested ACK

  7. laanwj merged this on May 4, 2015
  8. laanwj closed this on May 4, 2015

  9. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 12:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me