Change default nTxConfirmTarget to 2 #6126

pull morcos wants to merge 1 commits into bitcoin:master from morcos:change-confirm-target changing 2 files +3 −3

morcos commented at 9:21 PM on May 12, 2015: member

I think picking this number is mostly bike-shedding, but if/when #5159 gets merged, then it's more likely that estimateFee 1 will occasionally give a very high estimate, so setting the default lower will prevent accidentally spending too much on fees. I don't think these high estimates are problematic but just indicate busy times when you actually need a very high fee to be reliably confirmed in the next block. Also it's almost impossible to have a priority that is high enough to get you confirmed in the next block, so this helps with sending free transactions as well. (Note the default remains 25 on the GUI)
laanwj added the label Wallet on May 13, 2015
gavinandresen commented at 2:02 PM on May 13, 2015: contributor

I have no strong opinion, so ACK from me. This is trivial change of a default.
laanwj commented at 2:05 PM on May 13, 2015: member

I like this default change (I've complained about the default of 1 being too expensive before, and if that becomes worse...), utACK
laanwj commented at 9:58 AM on May 15, 2015: member

Needs rebase.
Change default nTxConfirmTarget to 2 4a38a50ff5
morcos force-pushed on May 15, 2015
morcos commented at 11:52 AM on May 15, 2015: member

rebased

in src/init.cpp:None in 4a38a50ff5

 332 | @@ -333,7 +333,7 @@ std::string HelpMessage(HelpMessageMode mode)
 333 |      strUsage += HelpMessageOpt("-salvagewallet", _("Attempt to recover private keys from a corrupt wallet.dat") + " " + _("on startup"));
 334 |      strUsage += HelpMessageOpt("-sendfreetransactions", strprintf(_("Send transactions as zero-fee transactions if possible (default: %u)"), 0));
 335 |      strUsage += HelpMessageOpt("-spendzeroconfchange", strprintf(_("Spend unconfirmed change when sending transactions (default: %u)"), 1));
 336 | -    strUsage += HelpMessageOpt("-txconfirmtarget=<n>", strprintf(_("If paytxfee is not set, include enough fee so transactions begin confirmation on average within n blocks (default: %u)"), 1));
 337 | +    strUsage += HelpMessageOpt("-txconfirmtarget=<n>", strprintf(_("If paytxfee is not set, include enough fee so transactions begin confirmation on average within n blocks (default: %u)"), 2));

laanwj commented at 3:20 PM on May 15, 2015:

BTW, ideally we'd define a DEFAULT_TX_CONFIRM_TARGET constant analogous to DEFAULT_TRANSACTION_FEE, to avoid this value having to be kept synchronized across three places

laanwj referenced this in commit 26e08a16a6 on May 18, 2015
laanwj commented at 7:09 AM on May 18, 2015: member

Merged via 2457dc4 (26e08a1) Prepended a commit 77ed59d to introduce a constant first, then change that to 2 in your commit.
laanwj closed this on May 18, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#5159 New fee estimation code