Various PEP8 Fixes #6156

1. 
   super3 commented at 6:15 pm on May 18, 2015: contributor

   https://www.python.org/dev/peps/pep-0008/
2. Various PEP8 Fixes 8afc59867b
3. 
   super3 commented at 8:34 pm on May 18, 2015: contributor

   About 600+ PEP8 style violations in /contrib alone. Just fixed the comma spacing errors first.
4. 
   laanwj commented at 9:24 am on May 19, 2015: member

   NACK. Don’t do this - these kinds of floods of minor whitespace changes break other pulls for no good reason.
5. 
   super3 commented at 12:46 pm on May 19, 2015: contributor

   @laanwj All of PEP8 violations I’m covering are in /contrib. With the exception of /contrib/debian these directories have not been touched for 4+ months. I agree that minor floods of whitespace on active code would cause problems, but that directory is far from active.
6. 
   super3 commented at 12:55 pm on May 19, 2015: contributor

   Guess the other question is should Bitcoin code even be PEP8 compliant?
7. 
   jonasschnelli commented at 1:01 pm on May 19, 2015: contributor

   I also tend to NACK this. Generally IMO clean code makes sense. But, at the moment there are many pull requests and it’s hard to keep focus on what is going on. IMO your PR does not produce a benefit for this project at first place. Somebody needs to review this. This requires time which is probably better spent at some other PRs.

   I think this PR could be something for the trivial branch https://github.com/theuni/bitcoin. This goes also in the same direction as the clang-everything PR (https://github.com/bitcoin/bitcoin/issues/5377, #5387)

8. 
   laanwj commented at 2:35 pm on May 19, 2015: member

   Some PEP8 “violations” are worse than others. E.g. using the wrong kind of indentation would be awful.

   But adding spaces to almost every line so that ‘,’ is lined up. No, that’s not important. Please don’t waste your time on this.

9. laanwj closed this on May 19, 2015

   ---

10. MarcoFalke locked this on Sep 8, 2021

Contributors
super3 laanwj jonasschnelli