Aligning tests with the supply algorithm. #6191

pull ghost wants to merge 1 commits into bitcoin:master from changing 2 files +8 −8

ghost commented at 10:55 PM on May 26, 2015: none

This is a refactoring of #5925, the least we can do to follow best practices on the testing side (à la TDD, tests shouldn't be enforcing improper, consensus-conflicting, behavior).

Hence, this PR is limited to test corrections only, setting up the stage for MAX_MONEY refactoring at some future point in time as per sipa's suggestion.
Aligning tests with the supply algorithm. c974cec25e
paveljanik commented at 6:00 AM on May 27, 2015: contributor

NACK, sorry. I do not think it is worth to touch this (the reasoning is all written in #5925).
sipa commented at 7:01 AM on May 27, 2015: member

How about we rename MAX_MONEY to AMOUNT_OVERFLOW_PROTECTION_THRESHOLD? Can we do then stop discussing the precise semantics of the maximum money constant?
laanwj commented at 7:04 AM on May 27, 2015: member

Fully agree with @sipa, couldn't have worded it better.
laanwj closed this on May 27, 2015
ghost commented at 10:26 PM on May 27, 2015: none

@sipa Sounds great. Please refer to #6197 for implementation.
MarcoFalke locked this on Sep 8, 2021

Contributors