Also add walletbackup.py to the pull-tester script
Fix walletbackup.py after directory restructuring #6194
pull sdaftuar wants to merge 1 commits into bitcoin:master from sdaftuar:fix-walletbackup changing 2 files +3 −2-
sdaftuar commented at 2:12 PM on May 27, 2015: member
-
ee9a2e4271
Fix walletbackup.py after directory restructuring
Also add walletbackup.py to rpc-tests.sh
-
jonasschnelli commented at 2:13 PM on May 27, 2015: contributor
Oh. I missed that. Thanks.
ACK (if travis succeed).
-
laanwj commented at 2:15 PM on May 27, 2015: member
Does anyone know why walletbackup.py was not included before? Is it a test that takes a long time?
- laanwj added the label Tests on May 27, 2015
-
sdaftuar commented at 2:16 PM on May 27, 2015: member
Seems to take about 30 seconds on my machine -- would it be better to move it to the set of scripts that don't run automatically?
-
laanwj commented at 2:19 PM on May 27, 2015: member
30 seconds doesn't sound too bad to me...
-
jonasschnelli commented at 2:19 PM on May 27, 2015: contributor
IMO it would be nice to have this test also within pull-tester/CI standard tests (even if it wasn't there before). @sdaftuar: https://github.com/bitcoin/bitcoin/blob/master/qa/rpc-tests/README.md is also a bit outdated. Maybe you find time to write something about the new classes, comparison test cases, etc.... ?
-
sdaftuar commented at 2:28 PM on May 27, 2015: member
@jonasschnelli Totally agree and sorry it's been taking a while, I've started work on implementing the first few of the java comparison tool's tests in the python framework. As part of that I'm reworking some of the interfaces a little bit to accommodate the test; my plan was to update the documentation and submit as part of that pull (hopefully sooner rather than later).
- laanwj merged this on May 29, 2015
- laanwj closed this on May 29, 2015
- laanwj referenced this in commit fb061c3391 on May 29, 2015
- MarcoFalke locked this on Sep 8, 2021
Contributors
Labels