- [net, trivial] explicitly use std::string for FindNode
- [net, trivial] remove using namespace std pollution in netbase.cpp
[net] 2 minor trivial changes to net/netbase #6208
pull Diapolo wants to merge 2 commits into bitcoin:master from Diapolo:net_trivial changing 2 files +4 −6-
Diapolo commented at 2:09 PM on May 31, 2015: none
-
49b22928ee
[net, trivial] explicitly use std::string for FindNode
- in OpenNetworkConnection we have a FindNode call, which gets a const char*, wheras we only have defined a FindNode for std::string
-
[net, trivial] remove using namespace std pollution in netbase.cpp d6922aad2c
-
maaku commented at 7:33 AM on June 1, 2015: contributor
Tested ACK
-
in src/netbase.cpp:None in d6922aad2c
34 | @@ -35,8 +35,6 @@ 35 | #define MSG_NOSIGNAL 0 36 | #endif 37 | 38 | -using namespace std;
laanwj commented at 7:53 AM on June 1, 2015:Good
laanwj merged this on Jun 1, 2015laanwj closed this on Jun 1, 2015laanwj referenced this in commit e9d0d252fc on Jun 1, 2015laanwj commented at 7:55 AM on June 1, 2015: memberutACK
Diapolo deleted the branch on Jun 1, 2015MarcoFalke locked this on Sep 8, 2021
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:15 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me