[net] 2 minor trivial changes to net/netbase #6208

pull Diapolo wants to merge 2 commits into bitcoin:master from Diapolo:net_trivial changing 2 files +4 −6
  1. Diapolo commented at 2:09 PM on May 31, 2015: none
    • [net, trivial] explicitly use std::string for FindNode
    • [net, trivial] remove using namespace std pollution in netbase.cpp
  2. [net, trivial] explicitly use std::string for FindNode
    - in OpenNetworkConnection we have a FindNode call, which gets a const
      char*, wheras we only have defined a FindNode for std::string
    49b22928ee
  3. [net, trivial] remove using namespace std pollution in netbase.cpp d6922aad2c
  4. maaku commented at 7:33 AM on June 1, 2015: contributor

    Tested ACK

  5. in src/netbase.cpp:None in d6922aad2c
      34 | @@ -35,8 +35,6 @@
      35 |  #define MSG_NOSIGNAL 0
      36 |  #endif
      37 |  
      38 | -using namespace std;
    


    laanwj commented at 7:53 AM on June 1, 2015:

    Good

  6. laanwj merged this on Jun 1, 2015
  7. laanwj closed this on Jun 1, 2015

  8. laanwj referenced this in commit e9d0d252fc on Jun 1, 2015
  9. laanwj commented at 7:55 AM on June 1, 2015: member

    utACK

  10. Diapolo deleted the branch on Jun 1, 2015
  11. MarcoFalke locked this on Sep 8, 2021
Contributors

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me