RecvLine wrong error message #626

issue xanatos opened this issue on November 9, 2011
  1. xanatos commented at 3:21 PM on November 9, 2011: none

    In irc.cpp there is a function bool RecvLine(SOCKET hSocket, string& strLine)

    The function, when fails, outputs messages like printf("IRC socket closed\n"); and printf("IRC recv failed: %d\n", nErr);.

    Sadly that function is used even outside of IRC: from net.cpp's GetMyExternalIP2().

    The easiest solution is to ignore it :-) The easy solution is to take away the "IRC " part from the error message. Another easy solution is to duplicate the function. The more complex solution is to pass a parameter about the connection type to RecvLine.

  2. laanwj commented at 4:03 PM on November 9, 2011: member

    If it is used outside irc.cpp it should probably not be in that file in the first place, but in util.cpp, for example. You're also right about removing the IRC from the error message.

  3. sipa referenced this in commit 013cb877b6 on Feb 19, 2012
  4. sipa referenced this in commit a3342d096f on Feb 19, 2012
  5. sje397 referenced this in commit f2c47aee83 on Feb 28, 2012
  6. sipa closed this on Jun 19, 2012

  7. coblee referenced this in commit 230c9337b7 on Jul 17, 2012
  8. ptschip referenced this in commit 2ab6f2fad2 on May 31, 2017
  9. fjahr referenced this in commit 1a02d6ce51 on Jul 24, 2019
  10. elichai referenced this in commit 461acf5c6c on Aug 22, 2019
  11. sipa referenced this in commit 6b9cd1520b on Sep 24, 2019
  12. kallewoof referenced this in commit 66c015529e on Oct 4, 2019
  13. kallewoof referenced this in commit c866f52e2a on Oct 4, 2019
  14. sipa referenced this in commit 544c1f35e7 on Nov 6, 2019
  15. sipa referenced this in commit d5cd9db7a3 on Nov 19, 2019
  16. sipa referenced this in commit de659898b6 on Jan 21, 2020
  17. sipa referenced this in commit 36362dfb90 on Jan 23, 2020
  18. jnewbery referenced this in commit 85e7d06351 on Mar 17, 2020
  19. sipa referenced this in commit 4977ac14d3 on Mar 18, 2020
  20. sipa referenced this in commit 5bf7fb5baa on Mar 18, 2020
  21. sipa referenced this in commit fb2a05e468 on Mar 19, 2020
  22. sipa referenced this in commit 497fad6f09 on Mar 21, 2020
  23. sipa referenced this in commit eae016f117 on Mar 22, 2020
  24. sipa referenced this in commit 4e37a7c2cb on Mar 27, 2020
  25. jnewbery referenced this in commit 9696dea839 on Apr 16, 2020
  26. jnewbery referenced this in commit a541fd0e87 on Apr 19, 2020
  27. sipa referenced this in commit c308759ea5 on Apr 19, 2020
  28. sipa referenced this in commit 4eaec32f1c on May 2, 2020
  29. sipa referenced this in commit ef7117193c on May 22, 2020
  30. sipa referenced this in commit 67f232b5d8 on Jun 9, 2020
  31. stackman27 referenced this in commit 78cde6f8c7 on Jun 26, 2020
  32. rajarshimaitra referenced this in commit 6b7cef987f on Aug 5, 2021
  33. MarcoFalke locked this on Sep 8, 2021
Contributors

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 06:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me