Fix getbalance * 0 #6276

1. 
   dgenr8 commented at 9:20 pm on June 12, 2015: contributor

   Change “getbalance *” not to use IsTrusted. The method and result now match the “getbalance <specific-account>” behavior. In particular, “getbalance * 0” now works.

   Ping @jonasschnelli, @wtogami

2. 
   wtogami commented at 9:45 pm on June 12, 2015: contributor

   Tag for 0.10 and 0.11 branches please.
3. dgenr8 force-pushed on Jun 12, 2015
4. dgenr8 force-pushed on Jun 12, 2015
5. Fix getbalance *

   Chance "getbalance *" not to use IsTrusted.  The method and result
   now match the "getbalance <specific-account>" behavior. In
   particular, "getbalance * 0" now works.
   
   Also fixed a comment -- GetGalance has required 1 confirmation
   for many years, and the default "getbalance *" behavior matches
   that.

   7d6a85ab5b
6. dgenr8 force-pushed on Jun 12, 2015
7. 
   jonasschnelli commented at 7:45 am on June 13, 2015: contributor

   utACK. Also utACK backport to 0.10 and 0.11. Because the accounting system has been marked for deprecation, we should slowly start to think about how the deprecation could lead/turn to a removal (or transformation to labels).
8. 
   thrasher- commented at 8:47 am on June 13, 2015: none

   Tested and works as expected, backporting to 0.10 requires renaming CheckFinalTx to IsFinalTx.
9. laanwj added the label Wallet on Jun 15, 2015
10. 
    laanwj commented at 7:02 am on June 15, 2015: member

    utACK
11. laanwj merged this on Jun 15, 2015
12. laanwj closed this on Jun 15, 2015

    ---

13. laanwj referenced this in commit f3d4dbb939 on Jun 15, 2015
14. laanwj referenced this in commit c9fd9078ce on Jun 15, 2015
15. laanwj referenced this in commit c7d28ce12a on Jun 15, 2015
16. 
    laanwj commented at 7:16 am on June 15, 2015: member

    Cherry-picked to 0.11 as c9fd9078ced17f6880274b4764736c5a9ab4eddb, to 0.10 as (thanks @thrasher-) c7d28ce12af216a691f7aac1ae48f11c979d604f
17. laanwj referenced this in commit 1e6449228f on Jun 15, 2015
18. laanwj referenced this in commit 0fd8464458 on Jun 15, 2015
19. dgenr8 deleted the branch on Sep 19, 2018
20. reddink referenced this in commit e5d9e28a0f on May 27, 2020
21. fanquake deleted a comment on Aug 15, 2021
22. fanquake locked this on Aug 15, 2021
23. fanquake deleted a comment on Aug 15, 2021

Contributors
dgenr8 wtogami jonasschnelli thrasher- laanwj

Labels
Wallet