Double logging of "addrLocalHost = %s\n" when using proxy/not accepting connections #630

issue xanatos opened this issue on November 10, 2011
  1. xanatos commented at 3:55 PM on November 10, 2011: none

    In net.cpp, around line 1688 there is the StartNode function.

    The first thing it does is try to find the local host ip and then it printf it (printf("addrLocalHost = %s\n", addrLocalHost.ToString().c_str());).

    Then, one line below, if there is a proxy configured or if bitcoin mustn't accept incoming connections, it drops the ip address it has found and it rewrites a second log line that is nearly the same (printf("addrLocalHost = %s\n", addrLocalHost.ToString().c_str());). The only thing that changes is the fact that the IP is now different. So in the log you'll get:

    addrLocalHost = something addrLocalHost = 0.0.0.0

    I think the second printf should be distinguished by the first (something like" setting addrLocalHost to 0.0.0.0 because of proxy/no incoming connection) and probably the first part (the one that finds the local ip) shouldn't directly be done in this situation.

  2. jgarzik commented at 9:59 PM on July 5, 2012: contributor

    Outdated (and probably fixed)

  3. jgarzik closed this on Jul 5, 2012

  4. ptschip referenced this in commit f6b7b8cb49 on Jun 15, 2017
  5. dexX7 referenced this in commit 723d793de6 on Jun 12, 2018
  6. fjahr referenced this in commit f34b0c3f35 on Jul 24, 2019
  7. elichai referenced this in commit 461acf5c6c on Aug 22, 2019
  8. sipa referenced this in commit 6b9cd1520b on Sep 24, 2019
  9. kallewoof referenced this in commit c866f52e2a on Oct 4, 2019
  10. sipa referenced this in commit 544c1f35e7 on Nov 6, 2019
  11. sipa referenced this in commit d5cd9db7a3 on Nov 19, 2019
  12. sipa referenced this in commit de659898b6 on Jan 21, 2020
  13. sipa referenced this in commit 36362dfb90 on Jan 23, 2020
  14. jnewbery referenced this in commit 85e7d06351 on Mar 17, 2020
  15. sipa referenced this in commit 4977ac14d3 on Mar 18, 2020
  16. sipa referenced this in commit 5bf7fb5baa on Mar 18, 2020
  17. sipa referenced this in commit fb2a05e468 on Mar 19, 2020
  18. sipa referenced this in commit 497fad6f09 on Mar 21, 2020
  19. sipa referenced this in commit eae016f117 on Mar 22, 2020
  20. sipa referenced this in commit 4e37a7c2cb on Mar 27, 2020
  21. jnewbery referenced this in commit 9696dea839 on Apr 16, 2020
  22. jnewbery referenced this in commit a541fd0e87 on Apr 19, 2020
  23. sipa referenced this in commit c308759ea5 on Apr 19, 2020
  24. sipa referenced this in commit 4eaec32f1c on May 2, 2020
  25. sipa referenced this in commit ef7117193c on May 22, 2020
  26. sipa referenced this in commit 67f232b5d8 on Jun 9, 2020
  27. stackman27 referenced this in commit 78cde6f8c7 on Jun 26, 2020
  28. rajarshimaitra referenced this in commit 88cee9d604 on Aug 5, 2021
  29. DrahtBot locked this on Sep 8, 2021
Contributors
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-29 03:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me