[Qt] simplify code for third party TX urls handling #6309

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:txurls changing 1 files +17 −22

Diapolo commented at 2:09 PM on June 19, 2015: none
- prefer a foreach over a for loop and use a function from GUIUtil, to use code we already have

[Qt] simplify code for third party TX urls handling

- prefer a foreach over a for loop and use a function from GUIUtil, to use
  code we already have

ed7ac4dea7

laanwj added the label GUI on Jun 22, 2015
Diapolo commented at 7:25 PM on June 23, 2015: none

I wanted to add such a thing for the peers tab, perhaps usable for a whois service or something. I'd love to get a quick ACK so I can re-use the new code :).
jonasschnelli commented at 7:31 PM on July 14, 2015: contributor

I don't see a simplification of the code in this PR. It's just another way of doing this IMO. This PR misses a benefit.
Diapolo commented at 9:25 AM on July 16, 2015: none

@jonasschnelli I think the foreach makes more sense, but also look at TransactionView::openThirdPartyTxUrl(), which now uses a GUIUtil function.
jgarzik commented at 1:44 PM on September 16, 2015: contributor

Weak NAK - do not see much simplification (though I do have a preference for un-indenting code)
Diapolo commented at 2:05 PM on September 16, 2015: none

@jgarzik IMHO the code in TransactionView::openThirdPartyTxUrl is quite easier to read, yeah the rest is likely another version of how one could do it...
Diapolo closed this on Oct 31, 2015
Diapolo deleted the branch on Oct 31, 2015
DrahtBot locked this on Sep 8, 2021

Contributors

Labels