[Qt] minor optimisations in peertablemodel #6317

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:peertablemodel changing 2 files +6 −14

Diapolo commented at 11:11 AM on June 21, 2015: none
- remove an unneeded include of net.h in peertablemodel.cpp
- add const after size() in PeerTablePriv
- remove 2x unneeded else in functions
- replace a (int) typecast by (QVariant) to use Qt style
paveljanik commented at 5:27 AM on June 22, 2015: contributor

Can you please remove { and } in a one-line ifs? utACK
Diapolo commented at 2:21 PM on June 22, 2015: none

@paveljanik @laanwj most of the time prefers { and } even for one-line ifs :).
jonasschnelli commented at 3:42 PM on June 23, 2015: contributor

I agree with @paveljanik: most one line ifs are without brackets and i think this is according to our code style / clang style.
Diapolo commented at 6:58 PM on June 23, 2015: none

@paveljanik @jonasschnelli Changed into one-line ifs :).
laanwj added the label GUI on Jul 2, 2015
Diapolo commented at 6:17 AM on July 6, 2015: none

@paveljanik @jonasschnelli @laanwj Do I get some ACKs, this should be easy to merge :).
paveljanik commented at 7:23 AM on July 6, 2015: contributor

utACK I think such changes should go to trivial...
jonasschnelli commented at 7:26 AM on July 6, 2015: contributor

utACK
jonasschnelli commented at 7:24 PM on July 14, 2015: contributor

ACK
Diapolo commented at 9:25 AM on July 29, 2015: none

@laanwj Can you please merge this trivial stuff :)?

[Qt] minor optimisations in peertablemodel

- remove an unneeded include of net.h in peertablemodel.cpp
- add const after size() in PeerTablePriv
- remove 2x unneeded else in functions
- replace a (int) typecast by (QVariant) to use Qt style
- remove unneeded include of peertablemodel.h from rpcconsole.cpp

92684bb872

Diapolo commented at 12:13 PM on August 10, 2015: none

@laanwj Ping once more.
Diapolo commented at 7:57 PM on September 9, 2015: none

@jonasschnelli IMHO, if we still support the GUI, we need another person wo is willing or able to merge GUI pulls... it's currently frustrating!
MarcoFalke commented at 12:54 PM on September 10, 2015: member

merge GUI pulls

It seems cosmetic-only changes to the source code usually get rejected? (#6511)

Still, utACK from me.
jgarzik merged this on Sep 16, 2015
jgarzik closed this on Sep 16, 2015
jgarzik referenced this in commit ca5e2a1864 on Sep 16, 2015
Diapolo deleted the branch on Sep 16, 2015
str4d referenced this in commit 2e4ce09eba on Jan 31, 2017
str4d referenced this in commit 1afb84314b on Feb 8, 2017
DrahtBot locked this on Sep 8, 2021

Contributors

Labels