This RPC is exactly identical to getblockcount. This duplication dates back to commit 22f721dbf23cf5ce9e3ded9bcfb65a3894cc0f8c when Satoshi created the RPC interface.
There's no need to have both, so we standardize on "count" which matches the naming convention in getconnectioncount.
NACK I agree with deprecating getblocknumber, however deprecation should not remove it from pCallTable yet. This would be a seperate patch for a later version. You should add comments like "// deprecated" to the calltable entry and the function itself so we can easily remove the code later.
midstate and hash1 are an example of RPC features that are deprecated but not removed yet.
Good point. I'll repair the patch and resubmit tomorrow.
This RPC is exactly identical to getblockcount. This duplication
dates back to commit 22f721dbf23cf5ce9e3ded9bcfb65a3894cc0f8c when
Satoshi created the RPC interface.
There's no need to have both, so we standardize on "count" which
matches the naming convention in getconnectioncount.
Following the tradition established with previously deprecated APIs,
getblocknumber continues to work, but it's not listed in the help
system.
ACK