[Qt] fix unused function warning in scicon.cpp #6327

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:scicon changing 1 files +7 −7

Diapolo commented at 7:19 PM on June 23, 2015: none
- MakeSingleColorImage() is unused in non Mac, silence the compiler warning

[Qt] fix unused function warning in scicon.cpp

- MakeSingleColorImage() is unused in non Mac, silence the compiler
  warning

157ed06a97

luke-jr commented at 8:37 PM on June 23, 2015: member

This seems unnecessarily convoluted IMO...
Diapolo commented at 8:41 PM on June 23, 2015: none

C'mon... @laanwj tried it, I didn't test it correctly and NOW the warning is gone. Please don't make it controversial if it works or give a better/easier solution and post a pull, thanks.
luke-jr commented at 8:44 PM on June 23, 2015: member

If you're going to use #if, just remove the whole function...?
penguin1333 commented at 8:50 PM on June 23, 2015: none

I'd say to just go with it. If it removes warnings, then less confusion :)

I didn't really review the code very much, but from what is said it does, it sounds good to me.

(Again, I did not read the code. I glanced at it, nor have I tested it.)
Diapolo commented at 8:51 PM on June 23, 2015: none

@luke-jr Try to #if the function and see what happens then -_-.
luke-jr commented at 9:58 PM on June 23, 2015: member

@Diapolo Simple, see #6328
jonasschnelli commented at 6:31 AM on June 24, 2015: contributor

Prefere #6328 because it's based on preprocessor macros.
laanwj commented at 5:30 PM on July 2, 2015: member

NACK, neither this nor #6328 is the solution we should use here.
laanwj closed this on Jul 2, 2015
Diapolo commented at 5:17 AM on July 3, 2015: none

@laanwj This is weird, as your solution (current master) doesn't fix the warning, while my patch and also Lukes did fix it. My idea was to get this fixed without such a discussion...
laanwj commented at 7:57 AM on July 3, 2015: member

@diapolo My point in #6328 is that non-breaking platform specific style differences should be based on a runtime decision, not on #ifdefs (or maybe one set of #ifdef at the initialization of the program, which can be overridden using an option). See my post here: #6328 (comment)
Diapolo deleted the branch on Aug 10, 2015
DrahtBot locked this on Sep 8, 2021

Contributors

Linked (view graph)

#6328 qt/scicon: Avoid warnings about unused MakeSingleColorImage